Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Stylelint 15 #134

Closed
wants to merge 1 commit into from
Closed

Conversation

fregante
Copy link

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/stylelint
npm WARN   peer stylelint@">=14" from [email protected]
npm WARN   node_modules/stylelint-config-xo
npm WARN     dev stylelint-config-xo@"^0.21.1" from the root project
npm WARN   1 more (the root project)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer stylelint@"^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0" from [email protected]
npm WARN node_modules/stylelint-config-xo/node_modules/stylelint-declaration-block-no-ignored-properties
npm WARN   stylelint-declaration-block-no-ignored-properties@"^2.5.0" from [email protected]
npm WARN   node_modules/stylelint-config-xo
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/stylelint
npm WARN   peer stylelint@"^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0" from [email protected]
npm WARN   node_modules/stylelint-config-xo/node_modules/stylelint-declaration-block-no-ignored-properties
npm WARN     stylelint-declaration-block-no-ignored-properties@"^2.5.0" from [email protected]
npm WARN     node_modules/stylelint-config-xo
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: [email protected]
npm WARN Found: [email protected]
npm WARN node_modules/stylelint
npm WARN   peer stylelint@">=14" from [email protected]
npm WARN   node_modules/stylelint-config-xo
npm WARN     dev stylelint-config-xo@"^0.21.1" from the root project
npm WARN   1 more (the root project)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer stylelint@"^14.0.0" from [email protected]
npm WARN node_modules/stylelint-config-xo/node_modules/stylelint-order
npm WARN   stylelint-order@"^5.0.0" from [email protected]
npm WARN   node_modules/stylelint-config-xo
npm WARN 
npm WARN Conflicting peer dependency: [email protected]
npm WARN node_modules/stylelint
npm WARN   peer stylelint@"^14.0.0" from [email protected]
npm WARN   node_modules/stylelint-config-xo/node_modules/stylelint-order
npm WARN     stylelint-order@"^5.0.0" from [email protected]
npm WARN     node_modules/stylelint-config-xo

Comment on lines -24 to 27
"stylelint": "^7.0.0 || ^8.0.0 || ^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0"
"stylelint": ">=7"
},
"engines": {
"node": ">=6"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like for the engines field below, you can just specify "greater than" instead of each version specifically

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this change is that there might be breaking changes in future versions, so I would always like to make sure that we actually support the version and then update peer deps version range.

Copy link
Author

@fregante fregante Feb 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but in practice it's breaking either way.

Today it breaks until you manually update the plugin, forcing people to ask you for an update.

With this change people might open an issue mentioning that it doesn't work.

Given the long list of supported versions, I dare to say that the latter is relatively unlikely.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but in practice it's breaking either way.

The difference is that the plugin does not claim to support the newest version like it would with this change.

A major version almost always means that there are some breaking changes, and we don't know what those breaking changes are going to be.

Today it breaks until you manually update the plugin, forcing people to ask you for an update.

This is by design, because things that this plugin uses from stylelint might break in future versions, so there needs to be a new version of this plugin to add support for a newer stylelint version. That's how it works in all the stylelint plugins and configs that I'm involved with.

@fregante fregante closed this Feb 12, 2023
@fregante fregante deleted the patch-1 branch February 12, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants