Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: QOS Ack Implementation #236

Merged
merged 17 commits into from
Aug 25, 2022
Merged

FR: QOS Ack Implementation #236

merged 17 commits into from
Aug 25, 2022

Conversation

denopink
Copy link
Contributor

Implements #228

What this includes

  • QOS Ack for simple event type messages
  • QOS Ack metrics
  • wrp-go update v3.1.3 to v3.1.4-dev.1
  • webpa-commons update v2.0.6 to v2.0.7-dev.1
  • general dependency updates

@denopink denopink self-assigned this Jul 20, 2022
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Merging #236 (d29e0df) into main (38e5c97) will increase coverage by 7.11%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   54.46%   61.58%   +7.11%     
==========================================
  Files          17       18       +1     
  Lines        1344     1481     +137     
==========================================
+ Hits          732      912     +180     
+ Misses        598      554      -44     
- Partials       14       15       +1
Flag Coverage Δ
unittests 61.58% <95.23%> (+7.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
outbounder.go 86.23% <66.66%> (-1.65%) ⬇️
ackDispatcher.go 96.00% <96.00%> (ø)
eventDispatcher.go 96.92% <96.92%> (ø)
metrics.go 100.00% <100.00%> (ø)
deviceStatus.go 96.05% <0.00%> (+47.36%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

denopink
denopink commented Jul 27, 2022
View reviewed changes
dispatcher.go Show resolved Hide resolved
johnabass
johnabass approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic! well-organized code

renaz6
renaz6 approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@renaz6 renaz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 🥳

@denopink
Copy link
Contributor Author

Currently deployed in cd for testing.

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@denopink denopink removed the request for review from mtrinh11 August 2, 2022 19:29
@denopink denopink mentioned this pull request Aug 15, 2022
Merged
@denopink denopink force-pushed the denopink/feature/qos-ack-implementation branch from b9b3dcb to e95a5e9 Compare August 25, 2022 17:13
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@denopink denopink merged commit 7156a66 into main Aug 25, 2022
@denopink denopink deleted the denopink/feature/qos-ack-implementation branch August 25, 2022 17:24
@denopink denopink mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaz6 renaz6 renaz6 approved these changes

@johnabass johnabass johnabass approved these changes

Assignees

@denopink denopink

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denopink @johnabass @renaz6