Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: JWK Migration #185

Merged
merged 43 commits into from
Aug 24, 2022
Merged

FR: JWK Migration #185

merged 43 commits into from
Aug 24, 2022

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Aug 12, 2022

Implements #183

What's included:

  • JWT Migration 183
    • updated to use clortho Resolver & Refresher
    • updated to use clortho metrics & logging
  • Update Config

New future work introduced:

@denopink denopink added enhancement jwk migration issues related to the jwk migration labels Aug 12, 2022
@denopink denopink self-assigned this Aug 12, 2022
@guardrails
Copy link

guardrails bot commented Aug 12, 2022

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@schmidtw
Copy link
Member

Does this have anything to do with QOS Acks?

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #185 (2dceaeb) into main (7b83a8f) will decrease coverage by 2.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #185      +/-   ##
==========================================
- Coverage   25.04%   22.91%   -2.13%     
==========================================
  Files           7        7              
  Lines         603      659      +56     
==========================================
  Hits          151      151              
- Misses        450      506      +56     
  Partials        2        2              
Flag Coverage Δ
unittests 22.91% <0.00%> (-2.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
primaryHandler.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@denopink denopink changed the title FR: QOS Ack Implementation FR: JWK Migration Aug 12, 2022
@denopink denopink marked this pull request as draft August 12, 2022 04:57
@denopink
Copy link
Contributor Author

Does this have anything to do with QOS Acks?

@schmidtw Nope, here are the PR's related to QOS Acks atm:

@denopink denopink marked this pull request as ready for review August 17, 2022 14:23
@denopink denopink requested a review from renaz6 August 18, 2022 16:05
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@denopink denopink merged commit c368196 into main Aug 24, 2022
@denopink denopink deleted the UpdateToUseClortho branch August 24, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement jwk migration issues related to the jwk migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants