diasdk: add package.#7175
Conversation
|
Looks working... |
|
Since the test uses Line 145 in 2e7f7f2 |
|
Does this only apply to the build tools rather than a full VS installation? $ ls "C:/Program Files/Microsoft Visual Studio/2022/Community"
╭────┬────────────────────────────────────────────────────────────────────────┬──────┬────────┬──────────────╮
│ # │ name │ type │ size │ modified │
├────┼────────────────────────────────────────────────────────────────────────┼──────┼────────┼──────────────┤
│ 0 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Common7 │ dir │ 4.0 kB │ a week ago │
│ 1 │ C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK │ dir │ 0 B │ a week ago │
│ 2 │ C:\Program Files\Microsoft Visual Studio\2022\Community\ImportProjects │ dir │ 0 B │ a week ago │
│ 3 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Licenses │ dir │ 4.0 kB │ a week ago │
│ 4 │ C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild │ dir │ 0 B │ 2 months ago │
│ 5 │ C:\Program Files\Microsoft Visual Studio\2022\Community\SDK │ dir │ 0 B │ a week ago │
│ 6 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Team Tools │ dir │ 4.0 kB │ a week ago │
│ 7 │ C:\Program Files\Microsoft Visual Studio\2022\Community\VB │ dir │ 0 B │ a week ago │
│ 8 │ C:\Program Files\Microsoft Visual Studio\2022\Community\VC │ dir │ 0 B │ 2 months ago │
│ 9 │ C:\Program Files\Microsoft Visual Studio\2022\Community\VC# │ dir │ 4.0 kB │ a week ago │
│ 10 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Web │ dir │ 0 B │ a week ago │
│ 11 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Xml │ dir │ 0 B │ a week ago │
│ 12 │ C:\Program Files\Microsoft Visual Studio\2022\Community\dotnet │ dir │ 0 B │ a week ago │
╰────┴────────────────────────────────────────────────────────────────────────┴──────┴────────┴──────────────╯
$ xmake l detect.sdks.find_dia_sdk
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.44.35207
nil |
|
Sorry, I don't have a (local) full VS installation. Can you test it in a real project/package? I just tested it in github actions and it works fine. |
|
Same. Run xmake l detect.sdks.find_dia_sdk
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.43.34
nilI think it should be: -- check sdkdir
-- if not found
-- check vstudio |
|
I mean create an actual project/package and then use (the source of the test action mentioned above) Or, I'm not sure if not being able to use it with the |
|
xrepo disable on_fetch when cross-compilation, we can merge it now. |
xmake-io/xmake#6453