Skip to content

diasdk: add package.#7175

Merged
star-hengxing merged 3 commits into
xmake-io:devfrom
Redbeanw44602:add/diasdk
May 27, 2025
Merged

diasdk: add package.#7175
star-hengxing merged 3 commits into
xmake-io:devfrom
Redbeanw44602:add/diasdk

Conversation

@Redbeanw44602
Copy link
Copy Markdown
Contributor

@luadebug
Copy link
Copy Markdown
Member

luadebug commented May 20, 2025

Looks working...

finding diasdk from xmake ..
checking for xmake::diasdk ... no
checking for DIA SDK directory ... E:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\DIA SDK
checking for local-repo::diasdk ... diasdk 
/mnt/e/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/DIA SDK
├── bin
│   ├── amd64
│   │   └── msdia140.dll
│   ├── arm
│   │   └── msdia140.dll
│   ├── arm64
│   │   └── msdia140.dll
│   └── msdia140.dll
├── idl
│   └── dia2.idl
├── include
│   ├── cvconst.h
│   ├── dia2.h
│   └── diacreate.h
├── lib
│   ├── amd64
│   │   └── diaguids.lib
│   ├── arm
│   │   └── diaguids.lib
│   ├── arm64
│   │   └── diaguids.lib
│   └── diaguids.lib
└── Samples
    └── DIA2Dump
        ├── Callback.h
        ├── DIA2Dump.cpp
        ├── DIA2Dump.h
        ├── DIA2Dump.sln
        ├── DIA2Dump.vcxproj
        ├── DIA2Dump.vcxproj.filters
        ├── makefile
        ├── PrintSymbol.cpp
        ├── PrintSymbol.h
        ├── Readme.txt
        ├── regs.cpp
        ├── regs.h
        ├── stdafx.cpp
        └── stdafx.h

@Redbeanw44602
Copy link
Copy Markdown
Contributor Author

Redbeanw44602 commented May 20, 2025

Since the test uses system = false, the fetch will fail, but it is actually available.🤨

extra.system = false

@star-hengxing
Copy link
Copy Markdown
Contributor

Does this only apply to the build tools rather than a full VS installation?

$ ls "C:/Program Files/Microsoft Visual Studio/2022/Community"
╭────┬────────────────────────────────────────────────────────────────────────┬──────┬────────┬──────────────╮
│  # │                                  name                                  │ type │  size  │   modified   │
├────┼────────────────────────────────────────────────────────────────────────┼──────┼────────┼──────────────┤
│  0 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Common7        │ dir  │ 4.0 kB │ a week ago   │
│  1 │ C:\Program Files\Microsoft Visual Studio\2022\Community\DIA SDK        │ dir  │    0 B │ a week ago   │
│  2 │ C:\Program Files\Microsoft Visual Studio\2022\Community\ImportProjects │ dir  │    0 B │ a week ago   │
│  3 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Licenses       │ dir  │ 4.0 kB │ a week ago   │
│  4 │ C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild        │ dir  │    0 B │ 2 months ago │
│  5 │ C:\Program Files\Microsoft Visual Studio\2022\Community\SDK            │ dir  │    0 B │ a week ago   │
│  6 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Team Tools     │ dir  │ 4.0 kB │ a week ago   │
│  7 │ C:\Program Files\Microsoft Visual Studio\2022\Community\VB             │ dir  │    0 B │ a week ago   │
│  8 │ C:\Program Files\Microsoft Visual Studio\2022\Community\VC             │ dir  │    0 B │ 2 months ago │
│  9 │ C:\Program Files\Microsoft Visual Studio\2022\Community\VC#            │ dir  │ 4.0 kB │ a week ago   │
│ 10 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Web            │ dir  │    0 B │ a week ago   │
│ 11 │ C:\Program Files\Microsoft Visual Studio\2022\Community\Xml            │ dir  │    0 B │ a week ago   │
│ 12 │ C:\Program Files\Microsoft Visual Studio\2022\Community\dotnet         │ dir  │    0 B │ a week ago   │
╰────┴────────────────────────────────────────────────────────────────────────┴──────┴────────┴──────────────╯
$ xmake l detect.sdks.find_dia_sdk
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.44.35207
nil

@Redbeanw44602
Copy link
Copy Markdown
Contributor Author

Redbeanw44602 commented May 22, 2025

Sorry, I don't have a (local) full VS installation. Can you test it in a real project/package? I just tested it in github actions and it works fine.

https://github.com/liteldev-free/DebugInfo/actions/runs/15192086086/job/42727205022#step:6:208

@star-hengxing
Copy link
Copy Markdown
Contributor

star-hengxing commented May 23, 2025

Same.

Run xmake l detect.sdks.find_dia_sdk
checking for Microsoft Visual Studio (x64) version ... 2022
checking for Microsoft C/C++ Compiler (x64) version ... 19.43.34
nil

I think it should be:

-- check sdkdir
-- if not found
-- check vstudio

@Redbeanw44602
Copy link
Copy Markdown
Contributor Author

I mean create an actual project/package and then use detect.sdks.find_dia_sdk inside it.

(the source of the test action mentioned above)
https://github.com/liteldev-free/DebugInfo/blob/9f059f2619a1ae3188573066a866d597325cd96b/xmake.lua#L88

Or, I'm not sure if not being able to use it with the xmake l is a problem🤔🤔

@star-hengxing
Copy link
Copy Markdown
Contributor

star-hengxing commented May 27, 2025

xrepo disable on_fetch when cross-compilation, we can merge it now.

@star-hengxing star-hengxing merged commit 7e57722 into xmake-io:dev May 27, 2025
65 of 73 checks passed
@Redbeanw44602 Redbeanw44602 deleted the add/diasdk branch May 27, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants