libllvm: add package.#6948
Conversation
Possible test failuresI have run the same tests in my own repo and based on my experience, the following test will not pass, but it actually works.
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new package "libllvm" that provides LLVM as a library with extended cross-compilation support and real support for version 19.1.7.
- Adds configuration and build instructions for the LLVM library package.
- Implements cross-compilation logic for Android and iOS.
- Provides helper functions via a new constants module to manage project and runtime library lists.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/l/libllvm/xmake.lua | Introduces package configuration, dependency management, and CMake build integration. |
| packages/l/libllvm/constants.lua | Provides helper functions to retrieve lists of LLVM-related projects and libraries. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
The import of DIA SDK (windows-only) has a little problem, waiting: |
|
Can someone merge #7175 first? This saves one test. |
|
Looks like xmake-io/xmake@d98c1ab broke this package, we need to undefine |
import("package.tools.cmake")
local opt = {}
opt.envs = cmake.buildenvs(package)
opt.envs.CMAKE_BUILD_TYPE = nil
cmake.install(package, configs, opt) |
|
Thanks for your reply. But this doesn't seem to work, except modifying the xmake source code, we can't undefine that variable.🙁 But... I found that simply keeping |
|
I think the package is ready to merge, all the tests failing are with code 143. |
|
[660/4518] This one is very huge? |
When a job is interrupted by github, the log may not be dumped completely. Try viewing the raw logs and you'll get: So, it is hard to determine what caused the job to be interrupted. If you run it on local machine (same environment), it will succeed. |
|
#7286 |
Differs from
xmake-repo/llvmPackaging principles
Keep llvm-project as default as possible, that is, keep xrepo as little as possible without making choices for the user.
Should splitting packages?
I discussed splitting the package with @star-hengxing in the telegram group, but I later thought that LLVM was more like a whole, so I didn't split it. If there are more opinions, we can discuss it.