Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fmt parsing error on windows #2481

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

jingkaimori
Copy link
Contributor

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

packages/f/fmt/xmake.lua Outdated Show resolved Hide resolved
@star-hengxing
Copy link
Contributor

fmtlib/fmt#3598

@waruqi
Copy link
Member

waruqi commented Aug 22, 2023

fmtlib/fmt#3598

那就是这个最近已经被修了咯,fmtlib/fmt@bd868f3

我看 patch ,它替换成的也不是 uFFFD 么。。\xEF\xBF\xBD

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


fmtlib/fmt#3598

That is, this has been fixed recently, fmtlib/fmt@bd868f3

I look at the patch, it is not replaced by uFFFD. . \xEF\xBF\xBD

@waruqi
Copy link
Member

waruqi commented Aug 22, 2023

或者可以直接走 add_patches 把这个 patch 打进来。。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Or you can go directly to add_patches to type this patch in. .

@jingkaimori
Copy link
Contributor Author

为什么这个patch的哈希码在Windows系统上匹配,其他系统上不匹配?

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Why does the hash code of this patch match on Windows systems but not others?

@waruqi
Copy link
Member

waruqi commented Aug 22, 2023

为什么这个patch的哈希码在Windows系统上匹配,其他系统上不匹配?

是不是你开了 git 的 core crlf 转换。。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Why does the patch's hashcode match on Windows but not on other systems?

Did you turn on git's core crlf conversion? .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants