-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add xmake build support #35
Conversation
Thank you, this is great addition, Do you also plan on making an xmake plugin template after this? We can put all community template links on the README for people to choose from. |
I don't think it's a good idea to remove that option because otherwise consumers will be saddled with another dependency they don't even use. Not all (xSE) plugins do hooking, even fewer of those use xbyak. I checked and all the other CommonLib's do default to OFF. As for a plugin template, there needs to be a package for |
Could you clarify the |
It sets the source ( |
I did not have this error in xmake yet, but I did encounter the exact compilation error as fmtlib/fmt#3598 days ago in cmake-msvc setup, this was before I manually specified I believe once fmt vcpkg port update their version to the latest with these PR fixes, this specific issue should not be present, but they haven't yet. Thank you for the fixes! Feel free to hit the merge button whenever your side of work is done and ready. Edit for clarity: |
+ Added various template links for people to choose from(vcpkg port, git submodule and xmake templates). + Added xmake package consume instruction. This complements #35 .
Builds with
msvc-cl
,xmake
does not currently support toolchain switching for packages on windows, soclang-cl
is off the table for now.How to build using
xmake
:This will fetch the project's package dependencies if they aren't already installed, and build all default targets. Packages aren't version pinned at the moment, this can be changed later if necessary.
As for options, there is one at the moment,
sfse_xbyak
which you can enable using:If a VS project is desired, one can be generated for you:
The project kind
vsxmake
still usesxmake
as the backend for building and such while allowing you to use the VS editor.