-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to load / refresh a TabContainer directly #2930
Conversation
cmp/tab/TabContainerModel.js
Outdated
// Trigger load / refreshes of TabContainer directly. | ||
// Note that we are intentionally *not* implementing LoadSupport here. | ||
//----------------------------- | ||
async loadAsync(loadSpec) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't fully understand this change, and would like to discuss, but it does seem to me that you should only need to override loadAsync and everything else should follow.
@TomTirapani -- Looks appealingly simple! Looking forward to discussing. Am a little concerned about unexpected effect of adding so many new RefreshContext's in, but it makes a lot of sense. |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
I just came across another use-case for this in a client app (I was able to work around it) |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Tried (and failed) to get the bundled yarn to stop showing up here as a diff, but I don't think anything actually changed. (Some line ending thing, maybe?) |
I fixed it with |
I still have a lingering question about whether we should have TabContainerModel delegate its doLoadAsync to this model. Seems like as an API user I would expect to just call refresh methods directly on the TabContainerModel, but am concerned we are somehow going to get double loading. |
tom reminded me that we discussed this at length in the spring, and we actually decided not to do that delegation, after originally trying it. We agreed to merge this as is so we can get the benefits of the new refreshContextModel, and shake out any issues. Can put a comment in the code, about potentially taking it further with a delegation. |
See issue: #2406
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
develop
branch as of last change.breaking-change
label + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.