Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TabContainer LoadSupport #2406

Closed
TomTirapani opened this issue Apr 20, 2021 · 1 comment
Closed

Improve TabContainer LoadSupport #2406

TomTirapani opened this issue Apr 20, 2021 · 1 comment
Assignees
@TomTirapani

Comments

@TomTirapani
Copy link
Member

TabContainers should be more intuitive / easier to integrate with load support

My suggestion would be to add TabContainerModel.loadAsync() / TabContainerModel.refreshAsync(). These methods respect the refresh mode of the tabs and should be equivalent to refreshing the outer RefreshContext. Typically, this would mean loading the visible tab, and having the other tabs refresh lazily.

Curious to hear other suggestions for how we can improve this crucial part of the API.
@TomTirapani TomTirapani self-assigned this Apr 20, 2021
@amcclain amcclain added this to the Medium Term milestone Jun 23, 2021
@TomTirapani TomTirapani mentioned this issue Mar 31, 2022
Merged
6 tasks
@TomTirapani
Copy link
Member Author

Finally got round to looking at this, and opened this PR: #2930
When ready to review, I can show the use-case in the client app that prompted this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TomTirapani TomTirapani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amcclain @TomTirapani