Introduce e2e tests #174
Merged
Introduce e2e tests #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mavimo
force-pushed
the
introduce-e2e-tests
branch
from
b408f1c to
a59410c
Compare
|
That's so really amazing, as I still didn't find any time do this very important mission! I will first take a closer look at your previous PRs before digging into this one, but that is awesome!!! |
mavimo
force-pushed
the
introduce-e2e-tests
branch
from
a59410c to
c1dcc3d
Compare
mavimo
force-pushed
the
introduce-e2e-tests
branch
7 times, most recently
from
6f11b0a to
dc4aada
Compare
mavimo
force-pushed
the
introduce-e2e-tests
branch
9 times, most recently
from
d1bef8e to
f30b0e2
Compare
|
@xetys the build is failing since the Eg: https://travis-ci.org/mavimo/hetzner-kube/builds/438378321 |
mavimo
force-pushed
the
introduce-e2e-tests
branch
from
f30b0e2 to
c3cfe78
Compare
mavimo
force-pushed
the
introduce-e2e-tests
branch
from
c3cfe78 to
4981720
Compare
|
we try to solve the issue with the key by merging that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #122
First tentative to introduce end-to-end test, currently only check that the command are invoked correctly and do not return issue.
This branch include also the fix reported in #173 used to set token during context creation.
@xetys @JohnnyQQQQ this PR is not mergeable but is a starting point to discuss how to setup an appropriate E2E test suite
NB: PR fail since need config on travis-CI side, you can see the build working on a configured env in: https://travis-ci.org/mavimo/hetzner-kube/branches branch
introduce-e2e-tests