Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix token flag ignored in context creation #173

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

mavimo
Copy link
Collaborator

@mavimo mavimo commented Aug 16, 2018

The context add command expose the token flag but the code ignore it and ask for token also if already provided, this make harder to programmatically create clusters (find during E2E test implementation)

@mavimo mavimo mentioned this pull request Aug 16, 2018
Copy link
Owner

@xetys xetys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, LGTM

@xetys xetys merged commit 2a45bc8 into xetys:master Aug 23, 2018
@mavimo mavimo deleted the fix-ignored-token-flag branch August 23, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants