Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save palette information to xpf #196

Closed
kanurag94 opened this issue Aug 12, 2020 · 3 comments · Fixed by #197
Closed

Save palette information to xpf #196

kanurag94 opened this issue Aug 12, 2020 · 3 comments · Fixed by #197

Comments

@kanurag94
Copy link
Member

XaoS xpf are position files which track palette currently using seed, shift and algorithm number value. After #195 #194 and #192 the ability to set custom palette was introduced. This should be saved to xpf only.

@kanurag94
Copy link
Member Author

Palette picker currently uses the first 31 colors to create a palette again using the chosen colors. While this is perfect for palette with seed, type, shift set to default or 0. This will fail to save information for palettes with these values set. The loaded palette will have somewhat different segments.
The first 31 colors are randomized throughout 65534 colors & we could not possibly know the colors to pick for creating palette configuration file (.gpl).
The possible solution is to save all the colors (65534 colors). This will block this issue.

@kovzol
Copy link
Contributor

kovzol commented Aug 14, 2020

How about with the following idea?
We should save the "default" palette only if the user changed the palette entries (or loaded a .gpl file).
Maybe a command (palettecolors 000000 01020f 210012 ...) could be useful.

@kanurag94
Copy link
Member Author

Thanks. I implemented this in the above PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants