Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve load/ save palette config #195

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Conversation

kanurag94
Copy link
Member

From #194 loading and saving of palette was introduced.

  • Users can now open the palette config file .gpl with GIMP/ or can manually edit it.
  • Options are now moved to Fractal -> Palette -> as Load Palette Config and Save Palette Config

Screenshot from 2020-08-12 00-08-49

@kanurag94 kanurag94 requested a review from kovzol August 11, 2020 19:13
@kanurag94
Copy link
Member Author

Generated gpl file

GIMP Palette
Name: XaoS_Palette
Columns: 16
#
 10   2  15	 color_0
139 104 129	 color_1
 18  17  33	 color_2
189 178   3	 color_3
 19  33  10	 color_4
 95 172 117	 color_5
  3  22   3	 color_6
241 214  87	 color_7
 20  24   3	 color_8
243 176  41	 color_9
 22  24  28	 color_10
229 186 107	 color_11
 18  33   4	 color_12
 71 116 157	 color_13
 21  10  32	 color_14
153  94  63	 color_15
  7  24  21	 color_16
 91 248 209	 color_17
 12   7  29	 color_18
 13 194 211	 color_19
  3  21  31	 color_20
 47  60 197	 color_21
 20  30  34	 color_22
 65 230  39	 color_23
  3  16  14	 color_24
195  64 121	 color_25
 18  10  12	 color_26
 53 202  59	 color_27
  8   3  12	 color_28
 23   4 237	 color_29
  1   7  14	 color_30

@kovzol kovzol merged commit 15ee54c into xaos-project:master Aug 11, 2020
@kovzol
Copy link
Contributor

kovzol commented Aug 11, 2020

Nice improvement.
I think we should save the palette information also in the .xpf file (and also in the .png, of course), if there is a custom palette used. Otherwise the default palette will be shown which is not expected.

@kanurag94
Copy link
Member Author

kanurag94 commented Aug 12, 2020

At this point I am not sure, if checking for default palette or not is easy. The xpf is parsed as a command parameter file, it'd be difficult to pass an array of colors or we can figure something out maybe. I have created issue #196 to track this.

@kanurag94 kanurag94 deleted the palettepatch branch August 12, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants