Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to save/load palette #194

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Conversation

kanurag94
Copy link
Member

Fixes #193
Type: Enhancement

What's new?
Easy loading and sharing of palette as a .gpl extension file.
Press x to launch palette picker

Screenshot from 2020-08-11 03-26-17

@kanurag94 kanurag94 requested a review from kovzol August 10, 2020 22:02
@kovzol kovzol merged commit 84b465f into xaos-project:master Aug 11, 2020
@kovzol
Copy link
Contributor

kovzol commented Aug 11, 2020

Thanks for this improvement!
For me, however, the usage of this window is not completely straightforward. I think:

  • When selecting a .gpl file to open, the palette should be changed immediately.
  • When selecting a .gpl file to save, the palette should be saved immediately.
    What do you think?

@kanurag94
Copy link
Member Author

When selecting a .gpl file to open, the palette should be changed immediately.

This was my first approach, but this meant a quite number of non reusable code to be added. I agree this is not very easy to operate on.

I think there are two options:-

  • Write extra code
  • Provide these options as fractal->palette ->. In this we can have three options load palette file, save palette config, and palette picker instead of just palette picker. Or move these options under file.

@kovzol
Copy link
Contributor

kovzol commented Aug 11, 2020

It is more intuitive to use the second option. I think it is better to keep these options in the menu where they are now (so not moving them under File).
I tried to import a .gpl file in GIMP but it was not successful. Also, when exporting a palette I got a file in .txt format like this:

#000000
#a800a8
#fc5454
...

Or am I missing something here?

@kanurag94
Copy link
Member Author

I didn't check with GIMP earlier. I can reproduce this.
I'll fix this.
Thanks for reviewing :D

@kanurag94
Copy link
Member Author

Also, when exporting a palette I got a file in .txt format like this:

This is basically exporting colors as hex.
Palettes are loaded in gimp app directory. To get the the actual palette, you can right click and use Show in file Manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to load/ save palette colors
2 participants