Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Added PickPhotosAsync#1795

Closed
GUOLDEV wants to merge 3 commits intoxamarin:mainfrom
GUOLDEV:gustavo/added-pickphotosasync
Closed

Added PickPhotosAsync#1795
GUOLDEV wants to merge 3 commits intoxamarin:mainfrom
GUOLDEV:gustavo/added-pickphotosasync

Conversation

@GUOLDEV
Copy link
Copy Markdown

@GUOLDEV GUOLDEV commented May 16, 2021

Description of Change

Implementing PickPhotosAsync to MediaPicker

Bugs Fixed

  • Related to issue #

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

List all API changes here (or just put None), example:

Added:

  • string Class.Property { get; set; }
  • void Class.Method();

Changed:

  • object Cell.OldPropertyName => object Cell.NewPropertyName

If there is an entirely new API, then you can use a more verbose style:

public static class NewClass {
    public static int SomeProperty { get; set; }
    public static void SomeMethod(string value);
}

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@opbld33
Copy link
Copy Markdown

opbld33 commented May 16, 2021

Docs Build status updates of commit 1b4a610:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error-InsufficientPermissionOnRepo] User mimisasouvanh does not have sufficient permission on https://github.com/xamarin/Essentials repository. Hint: required permission 'Read', actual permission 'None'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@dimonovdd
Copy link
Copy Markdown
Contributor

I didn't see the implementation in this PR. I also think that we cannot make such PRs until #1475 is merged

@@ -19,12 +19,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "Tests\Tests.csproj
EndProject
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably discard the change to this file

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove it, thanks 👍

@GUOLDEV
Copy link
Copy Markdown
Author

GUOLDEV commented May 25, 2021

I didn't see the implementation in this PR. I also think that we cannot make such PRs until #1475 is merged

Hi @dimonovdd , I just started trying to find the best way to get this task done, created this draft PR for visualisation and to get help to achieve the implementation. Please let me know if you have any questions or ideas how we can get it done 👍

@dimonovdd
Copy link
Copy Markdown
Contributor

You can copy the implementation from here.
But before you do this we need to combine PR #1475

@GUOLDEV
Copy link
Copy Markdown
Author

GUOLDEV commented May 25, 2021

Hi @dimonovdd, I did a quick look at your plugin and it looks great! It is definitely going to be a good addition to this plugin.

@dimonovdd
Copy link
Copy Markdown
Contributor

I think this will not become part of Xamarin.Essentials. But I will try to add this to MAUI.Essentials

@GUOLDEV
Copy link
Copy Markdown
Author

GUOLDEV commented May 30, 2021

@dimonovdd I worked a little bit on this issue and I got it working for iOS, I am having issues getting the correct file path using PHPickerResult. I will try to get it working for Android as well.

@jfversluis
Copy link
Copy Markdown
Member

This won't be happening for Xamarin.Essentials anymore unfortunately. Thanks so much for your time and effort here! We will make this happen for .NET MAUI!

@jfversluis jfversluis closed this Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants