Conversation
|
Docs Build status updates of commit 1b4a610: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
|
I didn't see the implementation in this PR. I also think that we cannot make such PRs until #1475 is merged |
| @@ -19,12 +19,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Tests", "Tests\Tests.csproj | |||
| EndProject | |||
There was a problem hiding this comment.
You should probably discard the change to this file
Hi @dimonovdd , I just started trying to find the best way to get this task done, created this draft PR for visualisation and to get help to achieve the implementation. Please let me know if you have any questions or ideas how we can get it done 👍 |
|
Hi @dimonovdd, I did a quick look at your plugin and it looks great! It is definitely going to be a good addition to this plugin. |
|
I think this will not become part of Xamarin.Essentials. But I will try to add this to MAUI.Essentials |
|
@dimonovdd I worked a little bit on this issue and I got it working for iOS, I am having issues getting the correct file path using PHPickerResult. I will try to get it working for Android as well. |
|
This won't be happening for Xamarin.Essentials anymore unfortunately. Thanks so much for your time and effort here! We will make this happen for .NET MAUI! |
Description of Change
Implementing PickPhotosAsync to MediaPicker
Bugs Fixed
Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.
API Changes
List all API changes here (or just put None), example:
Added:
string Class.Property { get; set; }void Class.Method();Changed:
object Cell.OldPropertyName=>object Cell.NewPropertyNameIf there is an entirely new API, then you can use a more verbose style:
Behavioral Changes
Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.
PR Checklist
mainat time of PR