Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

Implement the MediaPicker with PHPickerConfiguration#1475

Closed
mattleibow wants to merge 2 commits intomainfrom
dev/photos-1402
Closed

Implement the MediaPicker with PHPickerConfiguration#1475
mattleibow wants to merge 2 commits intomainfrom
dev/photos-1402

Conversation

@mattleibow
Copy link
Copy Markdown
Member

Description of Change

Implement the MediaPicker with PHPickerConfiguration for iOS 14+.

Bugs Fixed

API Changes

None.

Behavioral Changes

On iOS 14+, the new photos picker will be used.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@mattleibow mattleibow added this to the 1.7.0 milestone Oct 27, 2020

static FileResult PickerResultsToMediaFile(PHPickerResult[] results)
{
throw new NotImplementedException();
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmontemagno @mattleibow @Redth This is implemented in #1750

@jamesmontemagno
Copy link
Copy Markdown
Collaborator

AMAZE!

@akamud
Copy link
Copy Markdown

akamud commented Mar 22, 2022

I see this issue hasn't been updated in a while, and is still in draft. What's the story behind this? Is there anything blocking this from being merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Upgrade Media Picker on iOS to PHPickerViewController

5 participants