Skip to content

fix: Prevent Unlisted CSS from being excluded in the build when using CSS preprocessor #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aklinker1 merged 3 commits into from
Sep 3, 2025
Merged

fix: Prevent Unlisted CSS from being excluded in the build when using CSS preprocessor #1590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cef5945
fix: use `group.type` for CSS entrypoint check
PortalCube Apr 18, 2025
4dbaec2
test: add e2e test for css entrypoint
PortalCube Apr 18, 2025
9ddeb25
Merge branch 'main' into fix/unlisted-css
aklinker1 Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions packages/wxt/e2e/tests/output-structure.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,77 @@ describe('Output Directory Structure', () => {
expect(await project.fileExists('.output/chrome-mv3/unlisted.js'));
});

it('should support CSS entrypoints', async () => {
const project = new TestProject();

project.addFile(
'entrypoints/plain-one.css',
`body {
font: 100% Helvetica, sans-serif;
color: #333;
}`,
);

project.addFile(
'entrypoints/plain-two.content.css',
`body {
font: 100% Helvetica, sans-serif;
color: #333;
}`,
);

project.addFile(
'entrypoints/sass-one.scss',
`$font-stack: Helvetica, sans-serif;
$primary-color: #333;

body {
font: 100% $font-stack;
color: $primary-color;
}`,
);

project.addFile(
'entrypoints/sass-two.content.scss',
`$font-stack: Helvetica, sans-serif;
$primary-color: #333;

body {
font: 100% $font-stack;
color: $primary-color;
}`,
);

await project.build();

expect(await project.serializeOutput(['.output/chrome-mv3/manifest.json']))
.toMatchInlineSnapshot(`
".output/chrome-mv3/assets/plain-one.css
----------------------------------------
body{font:100% Helvetica,sans-serif;color:#333}

================================================================================
.output/chrome-mv3/assets/sass-one.css
----------------------------------------
body{font:100% Helvetica,sans-serif;color:#333}

================================================================================
.output/chrome-mv3/content-scripts/plain-two.css
----------------------------------------
body{font:100% Helvetica,sans-serif;color:#333}

================================================================================
.output/chrome-mv3/content-scripts/sass-two.css
----------------------------------------
body{font:100% Helvetica,sans-serif;color:#333}

================================================================================
.output/chrome-mv3/manifest.json
----------------------------------------
<contents-ignored>"
`);
});

it("should output to a custom directory when overriding 'outDir'", async () => {
const project = new TestProject();
project.addFile('entrypoints/unlisted.html', '<html></html>');
Expand Down
5 changes: 4 additions & 1 deletion packages/wxt/src/core/builders/vite/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,10 @@ export async function createViteBuilder(
async build(group) {
let entryConfig;
if (Array.isArray(group)) entryConfig = getMultiPageConfig(group);
else if (group.inputPath.endsWith('.css'))
else if (
group.type === 'content-script-style' ||
group.type === 'unlisted-style'
)
entryConfig = getCssConfig(group);
else entryConfig = getLibModeConfig(group);

Expand Down
Loading