Skip to content

Conversation

@PortalCube
Copy link
Contributor

Overview

Currently, the build function of viteBuilder determines whether a file is a CSS entrypoint by checking if its file extension ends with .css. As a result, Unlisted CSS using preprocessors like Sass are not built as CSS entrypoints and ignored during the build.

This PR updates the CSS entrypoint detection to use the group.type value and adds e2e tests for CSS entrypoints.

This is my first PR to an open-source project, so if there's anything I missed or did incorrectly, please let me know. Thanks!

Manual Testing

Please check the CSS entrypoint e2e tests I added to the PR.

Related Issue

This PR closes #1580.

@netlify
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 9ddeb25
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/68b846386acb390008d0c75e
😎 Deploy Preview https://deploy-preview-1590--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 3, 2025

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@1590

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1590

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@1590

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1590

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1590

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1590

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1590

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1590

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@1590

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1590

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1590

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@1590

wxt

npm i https://pkg.pr.new/wxt@1590

commit: 9ddeb25

@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.15%. Comparing base (7c59e9d) to head (9ddeb25).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1590      +/-   ##
==========================================
+ Coverage   80.83%   81.15%   +0.31%     
==========================================
  Files         131      131              
  Lines        6679     6680       +1     
  Branches     1091     1094       +3     
==========================================
+ Hits         5399     5421      +22     
+ Misses       1269     1248      -21     
  Partials       11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aklinker1 aklinker1 merged commit fdda812 into wxt-dev:main Sep 3, 2025
18 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Thanks for helping make WXT better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unlisted CSS using preprocessor does not build css file

2 participants