fix: use existing files in BenchmarkMinify

[ysmolski]

Use existing files for the simple benchmark instead of dev's temporaries.
Remove tests under WG_INTERNAL os env var.

@coderabbitai summary

[coderabbitai]

Walkthrough

The benchmark and unit tests in the minifier test file were updated to use different input files. A buffer length check was removed from the benchmark, and conditional test cases that depended on an environment variable were deleted from the unit tests. No changes were made to exported or public declarations.

Changes

File	Change Summary
v2/pkg/astminify/minify_test.go	Updated benchmark to use new input files, removed buffer length check, and deleted env-based test cases.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d9b862 and 4583a61.

📒 Files selected for processing (1)

• v2/pkg/astminify/minify_test.go (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

v2/pkg/astminify/minify_test.go (1)

Learnt from: SkArchon
PR: wundergraph/graphql-go-tools#1203
File: v2/pkg/engine/resolve/loader.go:63-67
Timestamp: 2025-07-02T15:28:02.073Z
Learning: In the graphql-go-tools codebase, result structs are consistently initialized with non-nil bytes.Buffer instances, making additional nil checks for res.out unnecessary defensive programming.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Linters
• GitHub Check: Build and test (go 1.23 / windows-latest)
• GitHub Check: Build and test (go 1.23 / ubuntu-latest)
• GitHub Check: Build and test (go 1.23 / windows-latest)
• GitHub Check: Build and test (go 1.23 / ubuntu-latest)
• GitHub Check: Linters

🔇 Additional comments (3)

v2/pkg/astminify/minify_test.go (3)

18-45: LGTM! Benchmark changes align with PR objectives.

The benchmark function has been successfully updated to use existing files instead of temporary files. The removal of the buffer length check also makes the benchmark more flexible and focused on performance measurement rather than specific output validation.

---

55-189: LGTM! Test cleanup removes environment-specific dependencies.

The test function now uses consistent file naming patterns (operation1.graphql to operation10.graphql with simpleschema.graphql) and has removed environment-specific conditional tests based on the WG_INTERNAL variable. This makes the tests more predictable and easier to maintain.

---

19-22: All new GraphQL fixtures are present

Verified that v2/pkg/astminify/operation1.graphql, v2/pkg/astminify/simpleschema.graphql, and all referenced operation1.graphql–operation10.graphql files exist, so the benchmark will run without missing-file errors.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.