fix: use int in netpoll's BenchmarkSocketFdReflect

[ysmolski]

This fixes the failing Benchmark in the netpoll lib.

Summary by CodeRabbit

• Refactor
  • Updated internal handling of socket file descriptors to use signed integer types instead of unsigned. No visible impact to end-user functionality.

[coderabbitai]

Walkthrough

The code updates the handling of socket file descriptors in tests by changing the type from unsigned to signed integers. This involves renaming a utility function, updating its return type, and modifying related variable types and method calls to use signed integers.

Changes

Files	Change Summary
v2/pkg/netpoll/fd_test.go	Renamed reflectSocketFDAsUint to reflectSocketFDAsInt, changed return type and internals from uint64/.Uint() to int64/.Int(), and updated related benchmark code accordingly.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d9b862 and da7c548.

📒 Files selected for processing (1)

• v2/pkg/netpoll/fd_test.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: Linters
• GitHub Check: Build and test (go 1.23 / windows-latest)
• GitHub Check: Build and test (go 1.23 / ubuntu-latest)
• GitHub Check: Build and test (go 1.23 / windows-latest)
• GitHub Check: Linters
• GitHub Check: Build and test (go 1.23 / ubuntu-latest)

🔇 Additional comments (5)

v2/pkg/netpoll/fd_test.go (5)

11-11: LGTM - Function signature correctly reflects the underlying data type.

The change from uint64 to int64 is correct since file descriptors are signed integers in Unix systems.

---

16-16: LGTM - Method call now matches the actual field type.

Using .Int() is correct since the Sysfd field is of type int in the underlying structure.

---

36-36: LGTM - Variable type consistent with function return type.

The int64 type aligns with the updated function signature.

---

41-41: LGTM - Function call updated to match the renamed function.

The call to reflectSocketFDAsInt is consistent with the function rename.

---

11-41: Changes are consistent and address the type mismatch issue.

The modifications correctly align the reflect-based socket file descriptor extraction with the actual underlying data type (int). The changes are internally consistent and should resolve the benchmark failure mentioned in the PR objectives.

Note: The raw syscall approach (rawSocketFD) still uses uint64, but this appears intentional since it uses a different extraction method via syscall.Conn.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[StarpTech]

@YuriBuerov could you reference a failing test?

[ysmolski]

@StarpTech

~/d/graphql-go-tools/v2/pkg/netpoll $ go test -bench=. ./...
panic: reflect: call of reflect.Value.Uint on int Value

goroutine 53 [running]:
reflect.Value.Uint(...)
	/Users/ys/g/src/reflect/value.go:2760
github.com/wundergraph/graphql-go-tools/v2/pkg/netpoll.reflectSocketFDAsUint({0x1006caaf0?, 0x140000a6040?})
	/Users/ys/d/graphql-go-tools/v2/pkg/netpoll/fd_test.go:16 +0x1c8
github.com/wundergraph/graphql-go-tools/v2/pkg/netpoll.BenchmarkSocketFdReflect(0x140000ee788)
	/Users/ys/d/graphql-go-tools/v2/pkg/netpoll/fd_test.go:41 +0x70
testing.(*B).runN(0x140000ee788, 0x1)
	/Users/ys/g/src/testing/benchmark.go:193 +0x128
testing.(*B).run1.func1()
	/Users/ys/g/src/testing/benchmark.go:215 +0x4c
created by testing.(*B).run1 in goroutine 1
	/Users/ys/g/src/testing/benchmark.go:208 +0x90
exit status 2
FAIL	github.com/wundergraph/graphql-go-tools/v2/pkg/netpoll	1.457s
FAIL

[StarpTech]

Thanks

[StarpTech]

LGTM