Skip to content

fix: include improvements in go-arena - #2959

Merged
ysmolski merged 1 commit into
mainfrom
yury/eng-9512-router-go-arena-improvements
Jun 11, 2026
Merged

fix: include improvements in go-arena#2959
ysmolski merged 1 commit into
mainfrom
yury/eng-9512-router-go-arena-improvements

Conversation

@ysmolski

@ysmolski ysmolski commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

This will result in faster handling of big responses. Bumped go-arena includes following fixes:

* forward-only cursor in monotonicArena.Alloc by @jensneuse
* harden arena hot paths and buffer semantics

Cursor's PR has extensive benchmarks for The Cosmo Router:

wundergraph/go-arena#3

Summary by CodeRabbit

  • Chores

    • Updated core dependencies to latest compatible versions.
  • Documentation

    • Updated benchmark documentation to reflect current script location.

This will result in faster handling of big responses.
Bumped go-arena includes following fixes:

    forward-only cursor in monotonicArena.Alloc by @jensneuse
    harden arena hot paths and buffer semantics

Cursor's PR has extensive benchmarks for The Cosmo Router:

wundergraph/go-arena#3
@ysmolski
ysmolski requested a review from a team as a code owner June 11, 2026 13:31
@ysmolski ysmolski changed the title fix: include improvement in go-arena fix: include improvements in go-arena Jun 11, 2026
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The PR updates WunderGraph library dependencies to newer patch versions across both router and router-tests modules, removes an unused indirect protoreflect dependency, and corrects a benchmark documentation command path.

Changes

Dependency Updates and Documentation

Layer / File(s) Summary
WunderGraph library version updates
router-tests/go.mod, router/go.mod
Direct dependencies graphql-go-tools/v2 (v2.4.4→v2.4.5) and go-arena (v1.1.0→v1.3.0) are updated in both module files.
Indirect dependency removal and benchmark documentation
router/go.mod, router/docs/Profiling.md
Indirect dependency jhump/protoreflect v1.17.0 is removed from router/go.mod; k6 benchmark command documentation is corrected from bench.js to bench/bench.js.

🎯 1 (Trivial) | ⏱️ ~3 minutes


Possibly related PRs

  • wundergraph/cosmo#2913: Both PRs directly bump github.com/wundergraph/graphql-go-tools/v2 in router/go.mod and router-tests/go.mod.
  • wundergraph/cosmo#2880: Both PRs directly bump github.com/wundergraph/graphql-go-tools/v2 version in Go module files.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: include improvements in go-arena' directly aligns with the main objective of bumping the go-arena dependency to include performance and robustness fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-6875aafa83f51300a33f0e4ce4f9859147cad1c0-nonroot

@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.36%. Comparing base (1e70ce8) to head (28fb9a1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2959      +/-   ##
==========================================
+ Coverage   66.17%   66.36%   +0.19%     
==========================================
  Files         258      258              
  Lines       27539    27539              
==========================================
+ Hits        18223    18277      +54     
+ Misses       7853     7812      -41     
+ Partials     1463     1450      -13     

see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ysmolski
ysmolski merged commit 9726c4f into main Jun 11, 2026
56 of 65 checks passed
@ysmolski
ysmolski deleted the yury/eng-9512-router-go-arena-improvements branch June 11, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants