Skip to content

fix: handle default values for slicingArguments - #2880

Merged
ysmolski merged 1 commit into
mainfrom
yury/eng-9557-requireoneslicingargument-default-rejects-queries-that-rely
May 21, 2026
Merged

fix: handle default values for slicingArguments#2880
ysmolski merged 1 commit into
mainfrom
yury/eng-9557-requireoneslicingargument-default-rejects-queries-that-rely

Conversation

@ysmolski

@ysmolski ysmolski commented May 21, 2026

Copy link
Copy Markdown
Contributor

This PR includes fixes of the engine:

  • handle default values for slicingArguments
  • multiply with 0 for empty lists in actual costs

Summary by CodeRabbit

  • Chores
    • Updated GraphQL tools library dependency to the latest patch version.

Review Change Stack

This PR includes fixes of the engine:

* handle default values for slicingArguments
* multiply with 0 for empty lists in actual costs
@ysmolski
ysmolski requested a review from a team as a code owner May 21, 2026 07:25

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b48db527-506b-482c-bf17-3ef2a1ce8e69

📥 Commits

Reviewing files that changed from the base of the PR and between 68e0963 and ccf066c.

⛔ Files ignored due to path filters (2)
  • router-tests/go.sum is excluded by !**/*.sum
  • router/go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • router-tests/go.mod
  • router/go.mod

Walkthrough

This PR updates the github.com/wundergraph/graphql-go-tools/v2 dependency from v2.3.0 to v2.3.1 across the router and router-tests modules. Both module files are updated consistently to the same patch version.

Changes

Dependency Version Update

Layer / File(s) Summary
graphql-go-tools/v2 version bump
router-tests/go.mod, router/go.mod
The graphql-go-tools/v2 dependency is bumped from v2.3.0 to v2.3.1 in both router and router-tests modules.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'fix: handle default values for slicingArguments' is directly related to the code changes. The go.mod updates show a dependency bump of github.com/wundergraph/graphql-go-tools/v2 from v2.3.0 to v2.3.1, which aligns with the PR objectives mentioning fixes for handling default values for slicingArguments and cost calculation in the engine.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

Router image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-5e67a6b531e8d7ea70cde6c6397398539942c727

@ysmolski
ysmolski requested a review from devsergiy May 21, 2026 07:29
@codecov

codecov Bot commented May 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.04%. Comparing base (be9d015) to head (ccf066c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
+ Coverage   64.47%   66.04%   +1.56%     
==========================================
  Files         319      258      -61     
  Lines       45359    27053   -18306     
  Branches     4927        0    -4927     
==========================================
- Hits        29245    17866   -11379     
+ Misses      16089     7759    -8330     
- Partials       25     1428    +1403     

see 577 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ysmolski
ysmolski merged commit 8ad7d44 into main May 21, 2026
54 of 63 checks passed
@ysmolski
ysmolski deleted the yury/eng-9557-requireoneslicingargument-default-rejects-queries-that-rely branch May 21, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants