feat(router): add options to configure router config assembling in split config poller - #2844
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Caution Review failedFailed to post review comments WalkthroughThis PR implements a complete split-config-loading feature enabling routers to assemble execution configurations from a base graph plus per-feature-flag configs fetched from CDN. It adds JWT feature claims, split-config polling with change detection, mux reuse optimization via per-mux contexts, manifest endpoints with feature gating, and comprehensive configuration/test coverage. ChangesSplit-Config-Loading Feature
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
⚔️ Resolve merge conflicts
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.1)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
| // SplitConfigPollerOption configures a splitConfigPoller. | ||
| type SplitConfigPollerOption func(*splitConfigPoller) | ||
|
|
||
| type ConfigRules struct { |
There was a problem hiding this comment.
Maybe a better name might be ConfigOptions
Summary by CodeRabbit
New Features
Documentation
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.