feat: add support for split config in cdn - #2839
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
275a4f2 to
c0e21c5
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cdn-server/cdn/src/index.ts`:
- Around line 381-382: The manifestBlob helper currently calls "const body =
await c.req.json()" without handling malformed/empty JSON; wrap the await
c.req.json() call in a try-catch inside manifestBlob (and any call sites) and on
a SyntaxError return a 400 response with a clear client error message (instead
of letting it throw a 500). Validate that body is present/has required fields
after parsing and return a 400 for missing/invalid payloads; rethrow or
propagate non-SyntaxError exceptions as appropriate. Ensure the changes
reference the manifestBlob helper and the POST manifest endpoints that invoke it
so the error handling covers all three new routes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8cfc60d7-fcd2-4637-a4c0-ec0e1848faf3
📒 Files selected for processing (2)
cdn-server/cdn/src/index.tscdn-server/cdn/test/cdn.test.ts
Summary by CodeRabbit
New Features
/manifest/for mapper configuration, latest versions, and feature flags.Tests
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.