Skip to content

feat: add support for split config in cdn - #2839

Merged
pepol merged 1 commit into
feat/split-configsfrom
peter/eng-9474-cdn-support
May 7, 2026
Merged

feat: add support for split config in cdn#2839
pepol merged 1 commit into
feat/split-configsfrom
peter/eng-9474-cdn-support

Conversation

@pepol

@pepol pepol commented May 7, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added new manifest upload endpoints under /manifest/ for mapper configuration, latest versions, and feature flags.
    • Introduced feature-gating for split-config-loading to control access to new manifest endpoints.
    • Enhanced JWT authentication to support feature claims for granular access control.
  • Tests

    • Added comprehensive tests for new manifest endpoints and feature-gating behavior.

Checklist

Open Source AI Manifesto

This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fddddb9d-38d9-4825-b1c4-e5d8438ff301

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pepol
pepol force-pushed the peter/eng-9474-cdn-support branch from 275a4f2 to c0e21c5 Compare May 7, 2026 13:58

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cdn-server/cdn/src/index.ts`:
- Around line 381-382: The manifestBlob helper currently calls "const body =
await c.req.json()" without handling malformed/empty JSON; wrap the await
c.req.json() call in a try-catch inside manifestBlob (and any call sites) and on
a SyntaxError return a 400 response with a clear client error message (instead
of letting it throw a 500). Validate that body is present/has required fields
after parsing and return a 400 for missing/invalid payloads; rethrow or
propagate non-SyntaxError exceptions as appropriate. Ensure the changes
reference the manifestBlob helper and the POST manifest endpoints that invoke it
so the error handling covers all three new routes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8cfc60d7-fcd2-4637-a4c0-ec0e1848faf3

📥 Commits

Reviewing files that changed from the base of the PR and between 6bf713b and c0e21c5.

📒 Files selected for processing (2)
  • cdn-server/cdn/src/index.ts
  • cdn-server/cdn/test/cdn.test.ts

Comment thread cdn-server/cdn/src/index.ts
Comment thread cdn-server/cdn/src/index.ts
Comment thread cdn-server/cdn/src/index.ts

@Aenimus Aenimus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pepol
pepol merged commit 1ae7d2e into feat/split-configs May 7, 2026
8 checks passed
@pepol
pepol deleted the peter/eng-9474-cdn-support branch May 7, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants