Skip to content

fix: (test) changes to v20 support#2806

Closed
comatory wants to merge 8 commits into
mainfrom
ondrej/eng-3812-implement-composedirective-directive
Closed

fix: (test) changes to v20 support#2806
comatory wants to merge 8 commits into
mainfrom
ondrej/eng-3812-implement-composedirective-directive

fix: prettier runtime dep

0036882
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 29, 2026 in 1s

40.28% (target 30.00%)

View this Pull Request on Codecov

40.28% (target 30.00%)

Details

Codecov Report

❌ Patch coverage is 83.88869% with 440 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.28%. Comparing base (403bd79) to head (0036882).

Files with missing lines Patch % Lines
composition/src/v1/normalization/utils.ts 47.98% 142 Missing ⚠️
composition/src/errors/errors.ts 35.71% 108 Missing ⚠️
composition/src/validation/validation.ts 78.82% 47 Missing ⚠️
...tion/src/v1/normalization/normalization-factory.ts 82.35% 39 Missing ⚠️
...omposition/src/v1/federation/federation-factory.ts 90.14% 33 Missing ⚠️
composition/src/schema-building/utils.ts 90.74% 25 Missing ⚠️
composition/src/v1/warnings/warnings.ts 8.00% 23 Missing ⚠️
...malization/batch-normalization/batch-normalizer.ts 94.90% 13 Missing ⚠️
composition/src/schema-building/ast.ts 68.75% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2806      +/-   ##
==========================================
- Coverage   46.28%   40.28%   -6.00%     
==========================================
  Files        1045      762     -283     
  Lines      139782   100686   -39096     
  Branches     8768     5142    -3626     
==========================================
- Hits        64702    40565   -24137     
+ Misses      73328    58421   -14907     
+ Partials     1752     1700      -52     
Files with missing lines Coverage Δ
...ctive-definition-data/directive-definition-data.ts 100.00% <100.00%> (ø)
composition/src/directive-definition-data/utils.ts 100.00% <100.00%> (ø)
composition/src/federation/federation.ts 100.00% <100.00%> (ø)
composition/src/federation/types/results.ts 100.00% <ø> (ø)
composition/src/index.ts 100.00% <100.00%> (ø)
composition/src/normalization/normalization.ts 100.00% <ø> (ø)
composition/src/schema-building/types/types.ts 100.00% <ø> (ø)
composition/src/subgraph/types/params.ts 100.00% <100.00%> (ø)
composition/src/subgraph/utils.ts 100.00% <100.00%> (ø)
composition/src/types/results.ts 100.00% <100.00%> (ø)
... and 26 more

... and 342 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.