-
Notifications
You must be signed in to change notification settings - Fork 233
fix: (test) changes to v20 support #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
comatory
wants to merge
8
commits into
main
from
ondrej/eng-3812-implement-composedirective-directive
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6f49452
feat: implement @composeDirective
Aenimus 5fdba76
chore: handle merge conflicts
Aenimus 334c6d2
chore: clean up and address PR feedback
Aenimus ccb7c22
fix: enforce NodeJS v22, v24
comatory 043a166
fix: do not override deps
comatory 19e7d53
Merge branch 'ondrej/eng-9463-cosmomonorepo-drop-nodejs-v20-support' …
comatory 309328f
fix: missing set methods in composition-go
comatory 0036882
fix: prettier runtime dep
comatory File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,20 @@ | ||
| var self = globalThis; | ||
| var global = globalThis; | ||
|
|
||
| function BigInt(value) { | ||
| return value; | ||
| return value; | ||
| } | ||
|
|
||
| class URL { | ||
| constructor(url, base) { | ||
| // urlParse is provided by the runtime | ||
| const result = urlParse(url, base || ''); | ||
| for (const prop in result) { | ||
| this[prop] = result[prop] | ||
| } | ||
| constructor(url, base) { | ||
| // urlParse is provided by the runtime | ||
| const result = urlParse(url, base || ''); | ||
| for (const prop in result) { | ||
| this[prop] = result[prop]; | ||
| } | ||
| } | ||
|
|
||
| static canParse(url, base = undefined) { | ||
| return urlCanParse(url, base || ''); | ||
| } | ||
| static canParse(url, base = undefined) { | ||
| return urlCanParse(url, base || ''); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.