Skip to content

chore: update default values for parser limits #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devsergiy merged 3 commits into from
Aug 7, 2025
Merged

chore: update default values for parser limits #2118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44aa891
chore: update default values for parser limits
devsergiy Aug 7, 2025
d3f6acc
chore: update fixtures
devsergiy Aug 7, 2025
f421267
Merge branch 'main' into sergiy/eng-7688-update-default-depth-and-fie…
devsergiy Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions router/pkg/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,8 +412,8 @@ type SecurityConfiguration struct {
}

type ParserLimitsConfiguration struct {
ApproximateDepthLimit int `yaml:"approximate_depth_limit,omitempty" envDefault:"100"` // 0 means disabled
TotalFieldsLimit int `yaml:"total_fields_limit,omitempty" envDefault:"500"` // 0 means disabled
ApproximateDepthLimit int `yaml:"approximate_depth_limit,omitempty" envDefault:"200"` // 0 means disabled
TotalFieldsLimit int `yaml:"total_fields_limit,omitempty" envDefault:"3500"` // 0 means disabled
}

type QueryDepthConfiguration struct {
Expand Down
4 changes: 2 additions & 2 deletions router/pkg/config/config.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2500,13 +2500,13 @@
"approximate_depth_limit": {
"type": "integer",
"description": "The approximate cumulative depth limit of a query, including fragments. Set to 0 to disable.",
"default": 100,
"default": 200,
"minimum": 0
},
"total_fields_limit": {
"type": "integer",
"description": "The total number of fields the parser will allow. Set to 0 to disable.",
"default": 500,
"default": 3500,
"minimum": 0
}
}
Expand Down
4 changes: 2 additions & 2 deletions router/pkg/config/testdata/config_defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,8 +313,8 @@
"ComplexityLimits": null,
"DepthLimit": null,
"ParserLimits": {
"ApproximateDepthLimit": 100,
"TotalFieldsLimit": 500
"ApproximateDepthLimit": 200,
"TotalFieldsLimit": 3500
},
"OperationNameLengthLimit": 512
},
Expand Down
4 changes: 2 additions & 2 deletions router/pkg/config/testdata/config_full.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,8 +672,8 @@
},
"DepthLimit": null,
"ParserLimits": {
"ApproximateDepthLimit": 100,
"TotalFieldsLimit": 500
"ApproximateDepthLimit": 200,
"TotalFieldsLimit": 3500
},
"OperationNameLengthLimit": 2000
},
Expand Down
Loading