Skip to content

chore: update default values for parser limits#2118

Merged
devsergiy merged 3 commits intomainfrom
sergiy/eng-7688-update-default-depth-and-field-count
Aug 7, 2025
Merged

chore: update default values for parser limits#2118
devsergiy merged 3 commits intomainfrom
sergiy/eng-7688-update-default-depth-and-field-count

Conversation

@devsergiy
Copy link
Copy Markdown
Member

@devsergiy devsergiy commented Aug 7, 2025

Summary by CodeRabbit

  • New Features
    • Increased the default parser depth limit from 100 to 200.
    • Increased the default total fields limit from 500 to 3500.

These changes enable improved handling of deeper and more complex data parsing by default.

Checklist

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 7, 2025

Walkthrough

The default values for parser limit configurations were increased in both the Go configuration struct and its associated JSON schema. The ApproximateDepthLimit was raised from 100 to 200, and TotalFieldsLimit from 500 to 3500. Corresponding test configuration files were updated to reflect these new defaults. No other fields or logic were modified.

Changes

Cohort / File(s) Change Summary
Parser Limits Default Value Update
router/pkg/config/config.go, router/pkg/config/config.schema.json
Increased default values for ApproximateDepthLimit (100→200) and TotalFieldsLimit (500→3500) in both Go struct and JSON schema.
Test Configuration Updates
router/pkg/config/testdata/config_defaults.json, router/pkg/config/testdata/config_full.json
Updated test configuration files to reflect increased default values for ApproximateDepthLimit and TotalFieldsLimit.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • fix: enforce parser limits #2068: Introduces parser hard limits and validation logic using these configuration values, directly related to the updated defaults.
  • fix: json schema #2082: Renames a schema property key for total fields limit; both PRs modify related configuration schema elements.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44aa891 and d3f6acc.

📒 Files selected for processing (2)
  • router/pkg/config/testdata/config_defaults.json (1 hunks)
  • router/pkg/config/testdata/config_full.json (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • router/pkg/config/testdata/config_defaults.json
  • router/pkg/config/testdata/config_full.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: build-router
  • GitHub Check: build_push_image (nonroot)
  • GitHub Check: build_push_image
  • GitHub Check: image_scan
  • GitHub Check: image_scan (nonroot)
  • GitHub Check: build_test
  • GitHub Check: integration_test (./events)
  • GitHub Check: integration_test (./telemetry)
  • GitHub Check: integration_test (./. ./fuzzquery ./lifecycle ./modules)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (go)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sergiy/eng-7688-update-default-depth-and-field-count

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot added the router label Aug 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 7, 2025

Router-nonroot image scan passed

✅ No security vulnerabilities found in image:

ghcr.io/wundergraph/cosmo/router:sha-245be22fef019dbde7e34fb07137b34f7e1400f2-nonroot

Copy link
Copy Markdown
Contributor

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devsergiy devsergiy merged commit 472c79b into main Aug 7, 2025
36 of 37 checks passed
@devsergiy devsergiy deleted the sergiy/eng-7688-update-default-depth-and-field-count branch August 7, 2025 15:40
@Noroth Noroth mentioned this pull request Sep 30, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants