feat: move cache control policy to standalone config section#1218
Merged
feat: move cache control policy to standalone config section#1218
Conversation
df-wg
commented
Sep 24, 2024
StarpTech
requested changes
Sep 25, 2024
* Verify with tests that set operations can override cache control policies
f4499fe to
5148e2a
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1155, we added in support for having a restrictive cache control policy, as part of the header rules. This pulls out the cache control configuration into a standalone section of the configuration, for clarity and extensibility.
It can now be configured like:
Additionally, in #1196 we had created a
setheader operation. This PR adds tests to validate that using thesetheader operation, we can, if necessary, override the cache control restrictions, as a 'break-glass' measure.Motivation and Context
TODO