Skip to content

feat: implement set header#1196

Merged
df-wg merged 5 commits intomainfrom
dave/eng-5670-set-header
Sep 20, 2024
Merged

feat: implement set header#1196
df-wg merged 5 commits intomainfrom
dave/eng-5670-set-header

Conversation

@df-wg
Copy link
Copy Markdown
Contributor

@df-wg df-wg commented Sep 19, 2024

Motivation and Context

This PR expands our header propagation abilities, by allowing users to define a value to set on all request/response headers in the format:

headers:
  all: # Header rules for all subgraphs
    request:
      - op: "set"
        name: "X-API-Key"
        value: ${SECRET_FOR_SUBGRAPH}

The set operation works both for requests and responses, and it can be applied globally (to all requests on the router), or only on a specific subgraph.

TODO

Comment thread router/pkg/config/config.schema.json Outdated
Copy link
Copy Markdown
Member

@jensneuse jensneuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment

@df-wg df-wg merged commit c3cc9ec into main Sep 20, 2024
@jensneuse jensneuse deleted the dave/eng-5670-set-header branch September 20, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants