-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jmx monitoring for enforcer #3067
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...nforcer/src/main/java/org/wso2/choreo/connect/enforcer/config/dto/ThreadPoolConfigMBean.java
Show resolved
Hide resolved
enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/JMXUtils.java
Show resolved
Hide resolved
...cer/src/main/java/org/wso2/choreo/connect/enforcer/metrics/jmx/api/ExtAuthMetricsMXBean.java
Show resolved
Hide resolved
enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/server/AuthServer.java
Show resolved
Hide resolved
pubudu538
reviewed
Sep 9, 2022
enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/JMXUtils.java
Outdated
Show resolved
Hide resolved
pubudu538
reviewed
Sep 9, 2022
enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/JMXAgent.java
Show resolved
Hide resolved
pubudu538
reviewed
Sep 9, 2022
...cer/src/main/java/org/wso2/choreo/connect/enforcer/metrics/jmx/api/ExtAuthMetricsMXBean.java
Show resolved
Hide resolved
pubudu538
reviewed
Sep 9, 2022
...enforcer/src/main/java/org/wso2/choreo/connect/enforcer/metrics/jmx/impl/ExtAuthMetrics.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments regarding logging.
...cer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanRegistrator.java
Outdated
Show resolved
Hide resolved
...cer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanRegistrator.java
Outdated
Show resolved
Hide resolved
...cer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanRegistrator.java
Outdated
Show resolved
Hide resolved
...cer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanRegistrator.java
Outdated
Show resolved
Hide resolved
enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/JMXAgent.java
Outdated
Show resolved
Hide resolved
VirajSalaka
reviewed
Sep 12, 2022
...rcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/config/ConfigHolder.java
Show resolved
Hide resolved
pubudu538
previously approved these changes
Sep 16, 2022
VirajSalaka
reviewed
Sep 19, 2022
...enforcer/src/main/java/org/wso2/choreo/connect/enforcer/metrics/jmx/impl/ExtAuthMetrics.java
Show resolved
Hide resolved
slahirucd7
reviewed
Oct 14, 2022
...rent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanManagementFactory.java
Outdated
Show resolved
Hide resolved
VirajSalaka
reviewed
Oct 17, 2022
enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/JMXAgent.java
Outdated
Show resolved
Hide resolved
VirajSalaka
reviewed
Oct 17, 2022
...cer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanRegistrator.java
Show resolved
Hide resolved
VirajSalaka
approved these changes
Oct 21, 2022
slahirucd7
added a commit
to slahirucd7/product-microgateway
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To enable jmx monitoring for enforcer.
Fixes #3076
JConsole Agent
JAVA_OPTS
property:jconsole
(in your java home /bin directory) and connect tolocalhost:11111
orservice:jmx:rmi://localhost:11111/jndi/rmi://localhost:9999/jmxrmi
.Jolokia Agent
Download Jolokia JVM-Agent from here. For example downloaded jar name is
jolokia-jvm-1.7.1.jar
Add the above jar to the enforcer droppings location.
Add following section to your
JAVA_OPTS
property (Use the exact name of the jar you added to the droppings replacing jolokia-jvm-1.7.1.jar):View ext auth service thread pool config
http://localhost:7777/jolokia/read/org.wso2.choreo.connect.enforcer:type=ThreadPoolConfig
View ext auth service metrics
http://localhost:7777/jolokia/read/org.wso2.choreo.connect.enforcer:type=ExtAuthMetrics
Reset ext auth service metrics record
http://localhost:7777/jolokia/exec/org.wso2.choreo.connect.enforcer:type=ExtAuthMetrics/resetExtAuthMetrics
Automation tests
Perf tests results - https://docs.google.com/spreadsheets/d/1WNLiA_2VXqMIIGtUjBM8UQ-4XVlv1kwk_1UvucXtxzk/edit#gid=0
Tested environments
OS: Darwin
Env: Docker
Maintainers: Check before merge