use string.format and comment corrected

wso2 · Oct 21, 2022 · 0ffeff4 · 0ffeff4
1 parent 6e33a8b
commit 0ffeff4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/JMXAgent.java b/enforcer-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/JMXAgent.java
@@ -48,8 +48,9 @@ public static void initJMXAgent() {
 
                 LocateRegistry.createRegistry(Integer.parseInt(rmiRegistryPort));
 
-                String jmxURL = "service:jmx:rmi://" + hostname + ":" + rmiServerPort
-                        + "/jndi/rmi://" + hostname + ":" + rmiRegistryPort + "/jmxrmi";
+                String jmxURL = String.format("service:jmx:rmi://%s:%s/jndi/rmi://%s:%s/jmxrmi", hostname,
+                        rmiServerPort,
+                        hostname, rmiRegistryPort);
                 JMXServiceURL jmxServiceURL = new JMXServiceURL(jmxURL);
 
                 jmxConnectorServer = JMXConnectorServerFactory.newJMXConnectorServer(jmxServiceURL, null,

diff --git a/...t/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanManagementFactory.java b/...t/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanManagementFactory.java
@@ -25,9 +25,10 @@
 public class MBeanManagementFactory {
 
     /*
-     * @return A MBeanServer instance.
      * If one already exists, it will return that else it will create a new one and
      * return.
+     * 
+     * @return A MBeanServer instance.
      */
     public static MBeanServer getMBeanServer() {
         MBeanServer mBeanServer;

diff --git a/...-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanRegistrator.java b/...-parent/enforcer/src/main/java/org/wso2/choreo/connect/enforcer/jmx/MBeanRegistrator.java
@@ -56,7 +56,7 @@ public static void registerMBean(Object mBeanInstance) throws RuntimeException {
                 className = className.substring(className.lastIndexOf('.') + 1);
             }
 
-            String objectName = SERVER_PACKAGE + ":type=" + className;
+            String objectName = String.format("%s:type=%s", SERVER_PACKAGE, className);
             try {
                 MBeanServer mBeanServer = MBeanManagementFactory.getMBeanServer();
                 Set set = mBeanServer.queryNames(new ObjectName(objectName), null);