double checked locking for getInstance method

wso2 · Sep 26, 2022 · 6e33a8b · 6e33a8b
1 parent 4fe299c
commit 6e33a8b
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/...orcer/src/main/java/org/wso2/choreo/connect/enforcer/metrics/jmx/impl/ExtAuthMetrics.java b/...orcer/src/main/java/org/wso2/choreo/connect/enforcer/metrics/jmx/impl/ExtAuthMetrics.java
@@ -45,11 +45,15 @@ private ExtAuthMetrics() {
      * 
      * @return ExtAuthMetrics
      */
-    public static synchronized ExtAuthMetrics getInstance() {
+    public static ExtAuthMetrics getInstance() {
         if (extAuthMetricsMBean == null) {
-            Timer timer = new Timer();
-            extAuthMetricsMBean = new ExtAuthMetrics();
-            timer.schedule(extAuthMetricsMBean, 0, REQUEST_COUNT_INTERVAL_MILLIS);
+            synchronized (ExtAuthMetrics.class) {
+                if (extAuthMetricsMBean == null) {
+                    Timer timer = new Timer();
+                    extAuthMetricsMBean = new ExtAuthMetrics();
+                    timer.schedule(extAuthMetricsMBean, 0, REQUEST_COUNT_INTERVAL_MILLIS);
+                }
+            }
         }
         return extAuthMetricsMBean;
     }