Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localize Or and Username labels in Authentication Portal and Recovery Portal #6826

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

HasiniSama
Copy link
Contributor

@HasiniSama HasiniSama commented Aug 27, 2024

Purpose

Fixes wso2/product-is#20936

  • The i18nKey variable is set to "Username" instead of "username". The username string does not get translated correctly due to this.
  • The string "or" is defined directly without resolving it according to the specific locale. Both of these needs to be fixed.
Screenshot 2024-09-09 at 17 54 59

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@pavinduLakshan pavinduLakshan merged commit 6ba7d2c into wso2:master Aug 28, 2024
6 checks passed
@HasiniSama HasiniSama mentioned this pull request Sep 10, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Username Label incorrectly generated when multi-attribute login is enabled
4 participants