Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Username Label incorrectly generated when multi-attribute login is enabled #20936

Closed
sanjulamadurapperuma opened this issue Aug 19, 2024 · 0 comments · Fixed by wso2/identity-apps#6826

Comments

@sanjulamadurapperuma
Copy link
Contributor

Describe the issue:

When enabling Multi Attribute Login in WSO2 Identity Server v7.0.0, it was observed that, after selecting a different locale from the dropdown menu available in the dropdown on the login page as shown below, the "Username or" section of the username label does not get translated to the relevant language.

Upon analyzing the code base, it was observed that at [1], the i18nKey variable is set to "Username" instead of "username". The username string does not get translated correctly due to this.

In addition, as per [2], the string "or" is defined directly without resolving it according to the specific locale. Both of these needs to be fixed.

[1] - https://github.com/wso2/identity-apps/blob/master/identity-apps-core/apps/recovery-portal/src/main/webapp/includes/username-label-resolver.jsp#L46
[2] - https://github.com/wso2/identity-apps/blob/master/identity-apps-core/apps/recovery-portal/src/main/webapp/includes/username-label-resolver.jsp#L63

How to reproduce:

  • Enable Multi-attribute login as shown below.
image
  • Navigate to an app like /myaccount. Observe that the login page displays the username label correctly in the default en_US locale.
image
  • Select a different locale from the dropdown (e.g. French) and observe the username label.
image
  • Note that the "Username or" section has not been translated. This needs to be fixed.

Optional Fields

Related issues:

Suggested labels:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants