-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing config-mgt view scope into connections api collection #6009
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6009 +/- ##
============================================
+ Coverage 40.15% 40.17% +0.01%
- Complexity 14163 14170 +7
============================================
Files 1734 1734
Lines 116849 116971 +122
Branches 20024 20025 +1
============================================
+ Hits 46917 46988 +71
- Misses 62718 62764 +46
- Partials 7214 7219 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -303,6 +303,7 @@ | |||
<Scope name="internal_authenticator_view"/> | |||
<Scope name="internal_governance_view"/> | |||
<Scope name="internal_extensions_view"/> | |||
<Scope name="internal_config_mgt_view"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent shall we add these changes to api-resource-collection.xml file as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
7b2f2c3
to
ea945bb
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11271327262
Proposed changes in this pull request
Resolves wso2/product-is#21317
When should this PR be merged
[Please describe any preconditions that need to be addressed before we
can merge this pull request.]
Follow up actions
[List any possible follow-up actions here; for instance, testing data
migrations, software that we need to install on staging and production
environments.]
Checklist (for reviewing)
General
Functionality
Code
Tests
Security
Documentation