Add 1-d array placeholder for nens for broadcasting#915
Merged
liujake merged 1 commit intowrf-model:developfrom May 29, 2019
Merged
Add 1-d array placeholder for nens for broadcasting#915liujake merged 1 commit intowrf-model:developfrom
liujake merged 1 commit intowrf-model:developfrom
Conversation
These modifications are required following PR#908 for release-v4.1.1. This commit fixes compiling for 4D-Var.
liujake
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: ep, ep_format2, bcast, WRFDA
SOURCE: Internal, JJ Guerrette
DESCRIPTION OF CHANGES:
These modifications are required following #908 for release-v4.1.1.
The interface to wrf_dm_bcast_* requires an array argument instead of a scalar. A compile error only arises when #908 and #900 are merged together. The fix was tested in a 4D-Var build, but should be general.
ISSUE: none
LIST OF MODIFIED FILES:
M var/da/da_setup_structures/da_setup_flow_predictors_ep_format2.inc
TESTS CONDUCTED: Compilation is fixed when release-v4.1.1 is merged into develop. This fix will also work in the current develop branch.