New DA ep_format option to read in ensemble perturbation (ep)#900
Merged
jjguerrette merged 1 commit intowrf-model:developfrom May 20, 2019
Merged
New DA ep_format option to read in ensemble perturbation (ep)#900jjguerrette merged 1 commit intowrf-model:developfrom
jjguerrette merged 1 commit intowrf-model:developfrom
Conversation
modified: Registry/registry.var modified: var/build/depend.txt modified: var/da/da_main/da_solve.inc modified: var/da/da_main/da_wrfvar_top.f90 modified: var/da/da_setup_structures/da_setup_flow_predictors.inc new file: var/da/da_setup_structures/da_setup_flow_predictors_ep_format2.inc new file: var/da/da_setup_structures/da_setup_flow_predictors_ep_format3.inc modified: var/da/da_setup_structures/da_setup_structures.f90
Contributor
|
Jamie, this is a great update to have in develop. Is it possible for you to also include corresponding writers for these different formats (i.e. replacements/alternatives to the current gen_be_ep2.f90)? |
jjguerrette
approved these changes
May 13, 2019
Contributor
jjguerrette
left a comment
jjguerrette
left a comment
There was a problem hiding this comment.
I'm fine if this goes into develop as-is, but the writers need to be included before release.
Contributor
|
@jjguerrette this one shall be now ready to merge. |
Contributor
|
@jamiebresch, does gen_be_v3 (#912) also write these new formats of ensemble perturbations? |
Contributor
Author
Yes, as implied by messages in both PR#900 and PR#912. |
Contributor
|
Thank you for updating the PR message here! |
liujake
pushed a commit
that referenced
this pull request
May 29, 2019
TYPE: bug fix KEYWORDS: ep, ep_format2, bcast, WRFDA SOURCE: Internal, JJ Guerrette DESCRIPTION OF CHANGES: These modifications are required following #908 for release-v4.1.1. The interface to wrf_dm_bcast_* requires an array argument instead of a scalar. A compile error only arises when #908 and #900 are merged together. The fix was tested in a 4D-Var build, but should be general. ISSUE: none LIST OF MODIFIED FILES: M var/da/da_setup_structures/da_setup_flow_predictors_ep_format2.inc TESTS CONDUCTED: Compilation is fixed when release-v4.1.1 is merged into develop. This fix will also work in the current develop branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: new feature
KEYWORDS: WRFDA, ep, ep_format
SOURCE: Jamie Bresch (NCAR)
DESCRIPTION OF CHANGES:
ep_format=1: (default) original format, double precision, each ep file is for one variable and one member, as the output from the current gen_be_ep2.
ep_format=11: same as ep_format=1 except data are in single precision
ep_format=2: single precision, each ep file is for one variable and all members
ep_format=3: single precision, each ep file is for one variable and all members but on decomposed patch domain
No impact on existing ep reading results.
New WRFDA code should work without any changes from the user when ep files are generated using the existing very inefficient gen_be_ep2 program.
New utility for generating ep in new formats (ep_format=1, 11, 2, 3 through namelist option) is proposed in PR #912.
LIST OF MODIFIED FILES:
modified: Registry/registry.var
modified: var/build/depend.txt
modified: var/da/da_main/da_solve.inc
modified: var/da/da_main/da_wrfvar_top.f90
modified: var/da/da_setup_structures/da_setup_flow_predictors.inc
new file: var/da/da_setup_structures/da_setup_flow_predictors_ep_format2.inc
new file: var/da/da_setup_structures/da_setup_flow_predictors_ep_format3.inc
modified: var/da/da_setup_structures/da_setup_structures.f90
TESTS CONDUCTED:
A case with 80-member 414x324x50 running with nproc=216.
The ep reading time:
ep_format=1 ~ 52 sec
ep_format=11 ~ 45 sec
ep_format=2 ~ 24 sec
ep_format=3 ~ 0.3 sec
Another major benefit to ep_format=3 is the reduced memory requirement.
New ep_format=11,2,3 produce identical analysis results.
RELEASE NOTE: New DA ep_format option to read in ensemble perturbation (ep) generated by existing gen_be_ep2 and new gen_be_v3 utilities.