Skip to content

VEGPARM.TBL update for NLCD40 Landuse crash#1733

Merged
weiwangncar merged 2 commits intowrf-model:release-v4.4.1from
coastwx:release-v4.4.1
Aug 2, 2022
Merged

VEGPARM.TBL update for NLCD40 Landuse crash#1733
weiwangncar merged 2 commits intowrf-model:release-v4.4.1from
coastwx:release-v4.4.1

Conversation

@coastwx
Copy link
Contributor

@coastwx coastwx commented May 3, 2022

WRFv4.4 crashes upon LSM initialization when NLCD40 landuse dataset is used because of the VEGPARM tables settings.

TYPE: bug fix

KEYWORDS: VEGPARM.TBL, NLCD40, LCZ_1, NUDAP

SOURCE: Robert Gilliam, US EPA

DESCRIPTION OF CHANGES:
Problem:
WRFv4.4 crashes when reading the VEGPARM.TBL file because of the the LCZ_* specs at the end of the main NLCD40 table entries.

Solution:
We just copied the values used for MODIS since the NLCD40 is a blend of US NLCD and MODIS.

ISSUE: For use when this PR closes an issue.
Fixes #123

LIST OF MODIFIED FILES: VEGPARM.TBL

TESTS CONDUCTED:

Does the mode fix the problem: Yes. We ran a full 2018 simulation at 12 km CONUS and 108 km N. Hemisphere scales and verified this works.
The Jenkins tests have passed.

RELEASE NOTE: VEGPARM.TBL updated for NLCD40 landuse case to work with recent updates of the LSM initialization that reads the file.

coastwx added 2 commits May 3, 2022 08:18
WRFv4.4 crashes upon LSM initialization when NLCD40 landuse dataset is used. This crash was found to be related to the LCZ_* specs at the end of the main NLCD40 table entries. We just copied the values used for MODIS since the NLCD40 is a blend of US NLCD and MODIS.
@coastwx coastwx requested a review from a team as a code owner May 3, 2022 12:28
@weiwangncar
Copy link
Collaborator

The Jenkins tests have passed:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           58
Number of Simulations  : 158           156        0
Number of Comparisons  : 95           92        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

Copy link
Collaborator

@dudhia dudhia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@weiwangncar weiwangncar merged commit f0a4f03 into wrf-model:release-v4.4.1 Aug 2, 2022
vlakshmanan-scala pushed a commit to scala-computing/WRF that referenced this pull request Apr 4, 2024
WRFv4.4 crashes upon LSM initialization when NLCD40 landuse dataset is used because of the VEGPARM tables settings.

TYPE: bug fix

KEYWORDS: VEGPARM.TBL, NLCD40, LCZ_1, NUDAP

SOURCE: Robert Gilliam, US EPA

DESCRIPTION OF CHANGES:
Problem:
WRFv4.4 crashes when reading the VEGPARM.TBL file because of the the LCZ_* specs at the end of the main NLCD40 table entries.

Solution:
We just copied the values used for MODIS since the NLCD40 is a blend of US NLCD and MODIS.

ISSUE: For use when this PR closes an issue.
Fixes wrf-model#123

LIST OF MODIFIED FILES: VEGPARM.TBL

TESTS CONDUCTED:

Does the mode fix the problem: Yes. We ran a full 2018 simulation at 12 km CONUS and 108 km N. Hemisphere scales and verified this works.
The Jenkins tests have passed.

RELEASE NOTE: VEGPARM.TBL updated for NLCD40 landuse case to work with recent updates of the LSM initialization that reads the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants