Fix for lh_urb2d diagnostics#1363
Merged
weiwangncar merged 1 commit intowrf-model:release-v4.2.2from Jan 13, 2021
weiwangncar:noahmp-urban-fix
Merged
Fix for lh_urb2d diagnostics#1363weiwangncar merged 1 commit intowrf-model:release-v4.2.2from weiwangncar:noahmp-urban-fix
weiwangncar merged 1 commit intowrf-model:release-v4.2.2from
weiwangncar:noahmp-urban-fix
Conversation
Collaborator
Author
|
Jenkins tests have all passed: |
dudhia
approved these changes
Jan 13, 2021
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: lh_urb2d, diagnostics, noahmp SOURCE: internal (reported by Xin-Zhong Liang) DESCRIPTION OF CHANGES: Problem: lh_urb2d was inconsistent with other urban budget arrays sh_urb2d, g_urb2d, and rn_urb2d by being the only one multiplied by the urban fraction making it a grid cell average instead of urban area average. This is only a diagnostic for output with using of an urban option together with NoahMP. Solution: Divide lh_urb2d by frc_urb2d. Won't affect model run results apart from this diagnostic. These arrays are not in default history output. LIST OF MODIFIED FILES: phys/module_sf_noahmpdrv.F TESTS CONDUCTED: Only Jenkins tests were performed. The Jenkins tests are all passing. RELEASE NOTE: Fix lh_urb2d diagnostic to be urban area average instead of grid cell average consistent with other urb2d diagnostics associated with NoahMP. No effect on run results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: lh_urb2d, diagnostics, noahmp
SOURCE: internal (reported by Xin-Zhong Liang)
DESCRIPTION OF CHANGES:
Problem:
lh_urb2d was inconsistent with other urban budget arrays sh_urb2d, g_urb2d, and rn_urb2d by being the only one multiplied by the urban fraction making it a grid cell average instead of urban area average. This is only a diagnostic for output with using of an urban option together with NoahMP.
Solution:
Divide lh_urb2d by frc_urb2d. Won't affect model run results apart from this diagnostic. These arrays are not in default history output.
LIST OF MODIFIED FILES:
phys/module_sf_noahmpdrv.F
TESTS CONDUCTED:
RELEASE NOTE: Fix lh_urb2d diagnostic to be urban area average instead of grid cell average consistent with other urb2d diagnostics associated with NoahMP. No effect on run results.