Fix for lh_urb2d diagnostic#1361
Closed
dudhia wants to merge 5 commits intowrf-model:release-v4.2.2from
Closed
Conversation
This reverts commit f51ac50.
Collaborator
Author
|
Did not succeed in changing the history. It comes from my fork. |
Collaborator
|
@dudhia Can you please change the base? |
Collaborator
Author
|
Yes, I just did. I was not able to remove the spurious history after a few
attempts,
so you saw another PR which I closed.
…On Tue, Jan 12, 2021 at 4:26 PM weiwangncar ***@***.***> wrote:
@dudhia <https://github.com/dudhia> Can you please change the base?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1361 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEIZ77FH3XUR46EAPDCKFGTSZTLD7ANCNFSM4V753MNQ>
.
|
Collaborator
Author
|
replaced by #1363 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: lh_urb2d diagnostic for urban models
SOURCE: internal (reported by Xin-Zhong Liang)
DESCRIPTION OF CHANGES:
Problem:
lh_urb2d was inconsistent with other urban budget arrays sh_urb2d, g_urb2d, and rn_urb2d by being the only one multiplied by the urban fraction making it a grid cell average instead of urban area average. This is only a diagnostic for output.
Solution:
Divide lh_urb2d by frc_urb2d
Won't affect model run results apart from this diagnostic. These arrays are not in default history output.
ISSUE:
LIST OF MODIFIED FILES:
phys/module_sf_noahmpdrv.F
TESTS CONDUCTED:
None.
RELEASE NOTE:
Fix lh_urb2d diagnostic to be urban area average instead of grid cell average consistent with other urb2d diagnostics. No effect on run results.