km_opt=5 causes several divide by 0#1304
Merged
weiwangncar merged 1 commit intowrf-model:release-v4.2.2from Dec 29, 2020
Merged
km_opt=5 causes several divide by 0#1304weiwangncar merged 1 commit intowrf-model:release-v4.2.2from
weiwangncar merged 1 commit intowrf-model:release-v4.2.2from
Conversation
matzegoebel
force-pushed
the
km_opt5_divide_by_0
branch
from
e3d46fd to
d420eb1
Compare
Collaborator
|
@zhangxsms Can you please review this fix? |
matzegoebel
commented
Oct 23, 2020
Contributor
|
Jenkins testing is OK |
zhangxsms
approved these changes
Oct 26, 2020
Contributor
zhangxsms
left a comment
zhangxsms
left a comment
There was a problem hiding this comment.
I have reviewed them and the suggested fixes are all physically correct.
Thanks for Matthias's careful inspection!
Collaborator
|
I'm ok with this PR. Is there anything else that needs to be done for this PR? |
Contributor
|
@weiwangncar @dudhia @matzegoebel |
Contributor
Author
|
what are we actually waiting for here? |
Collaborator
|
I will approve |
dudhia
approved these changes
Dec 15, 2020
vlakshmanan-scala
pushed a commit
to scala-computing/WRF
that referenced
this pull request
Apr 4, 2024
TYPE: bug fix KEYWORDS: 3D TKE, km_opt, divide by zero SOURCE: Matthias Göbel (University of Innsbruck) DESCRIPTION OF CHANGES: Problem: When compiling WRF with the -D option, several divide-by-zero errors happen in the km_opt=5 scheme. This PR fixes the problems, and the changes are approved by the developer. LIST OF MODIFIED FILES: dyn_em/module_diffusion_em.F TESTS CONDUCTED: Jenkins testing is all PASS. RELEASE NOTE: Fixed divide by zero in the 3D-TKE option km_opt=5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: 3D TKE, km_opt, divide by zero
SOURCE: Matthias Göbel (University of Innsbruck)
DESCRIPTION OF CHANGES:
Problem:
When compiling WRF with the -D option, several divide-by-zero errors happen in the km_opt=5 scheme. Some of these are the same as in the Shin-Hong PBL scheme (see pull request #1219). I tried to fix all the appearing errors, but some of them are not so straightforward to fix (see annotations in the code).
LIST OF MODIFIED FILES:
dyn_em/module_diffusion_em.F
TESTS CONDUCTED:
RELEASE NOTE: fixed divide by zero in km_opt=5