fixed divide by zero in Shin-Hong PBL

[matzegoebel]

TYPE: bug fix

KEYWORDS: shin hong, divide by zero

SOURCE: Matthias Göbel (University of Innsbruck)

DESCRIPTION OF CHANGES: When using the Shin-Hong PBL with initially zero wind, divisions by zero can occur. This bug fix includes if-statements to avoid a crash of the model. All limit values that are used instead of the divisions by zero should be mathematically correct, except for the third change where I guessed the appropriate limit value.

LIST OF MODIFIED FILES: phys/module_bl_shinhong.F

RELEASE NOTE: fixed divide by zero in Shin-Hong PBL

[dudhia]

I have forwarded this to Hailey Shin to look at, Jimy

…

On Mon, Jun 22, 2020 at 6:02 AM Matthias Göbel ***@***.***> wrote: @MATZE77 <https://github.com/Matze77> requested review from @wrf-model/physics on: #1219 <#1219> fixed divide by zero in Shin-Hong PBL as a code owner. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#1219 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77HV5KVTUDXZMEBE2PTRX5B6FANCNFSM4OEQRMVA> .

[davegill]

@dudhia
Jimy,
Would you ping Hailey again to review?

[davegill]

@dudhia @weiwangncar

From Hailey:

Yes, I have reviewed them and the suggested fixes are physically correct.
The fixes are correct in that they remove zero denominators, and also correct in terms of physics behind.

Can this get approved?

[weiwangncar]

I'm ok with the fix, if Hailey is.

[dudhia]

Yes.

…

On Mon, Jul 6, 2020 at 8:57 PM weiwangncar ***@***.***> wrote: I'm ok with the fix, if Hailey is. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1219 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEIZ77DRTAMQF4CBX5XSJ3DR2KFHZANCNFSM4OEQRMVA> .