Fix WRFPlus compilation issue#1090
Merged
liujake merged 2 commits intowrf-model:developfrom Feb 12, 2020
Merged
Conversation
modified: main/depend.common modified: share/mediation_integrate.F modified: wrftladj/module_diffusion_em_ad.F
liujake
requested review from
a team,
brankokosovic,
domingom and
pedro-jm
as code owners
davegill
reviewed
Feb 12, 2020
main/depend.common
Outdated
| module_ra_rrtmg_lwk.o \ | ||
| module_ra_rrtmg_swk.o \ | ||
| module_ra_cam.o \ | ||
| module_ra_farms.o \ |
Contributor
There was a problem hiding this comment.
@liujake
Jake,
There is a separate PR for this mod, which is a more general fix than just for DA.
Please remove it.
Contributor
Author
There was a problem hiding this comment.
I thought this should disappear after you merge your PR. Apparently not.
Contributor
There was a problem hiding this comment.
No such luck.
I can easily remove this line via github, if you like.
Contributor
|
@jjguerrette
|
jjguerrette
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: wrfplus, TL/AD code
SOURCE: internal
DESCRIPTION OF CHANGES:
Two recent WRF model code changes break the wrfplus compilation:
This modification allowed the CTSM development to use standard ESMF without conflicting
with WRF old ESMF library namespace.
Commit 8af5385, PR Enabling WRF build with ESMF library #1066 "Enabling WRF build with ESMF library"
Commit d059afe, PR Add a scale-adaptive 3DTKE parameterization scheme as a subgrid mixing option #972 "Add a scale-adaptive 3DTKE parameterization scheme as a subgrid mixing option
Commit 6d95883, PR SMS3dTKE: Remove broken packaging for km_opt=5 #1012 "SMS3dTKE: Remove broken packaging for km_opt=5"
Commit 94e5ed9, PR Add missing "IF km_opt==5" tests for diag computations #1013 "Add missing "IF km_opt==5" tests for diag computations"
Commit dd0c209, PR Fixing the problem that km_opt=5 breaks km_opt=2 and cleaning codes #1026 "Fixing the problem that km_opt=5 breaks km_opt=2 and cleaning codes"
LIST OF MODIFIED FILES:
M share/mediation_integrate.F
M wrftladj/module_diffusion_em_ad.F
TESTS CONDUCTED: wrfplus code compiles now.