SMS3dTKE: Remove broken packaging for km_opt=5#1012
Merged
davegill merged 2 commits intowrf-model:developfrom Nov 18, 2019
Merged
SMS3dTKE: Remove broken packaging for km_opt=5#1012davegill merged 2 commits intowrf-model:developfrom
davegill merged 2 commits intowrf-model:developfrom
Conversation
TYPE: bug fix KEYWORDS: packaging, sms3dtke SOURCE: Internal DESCRIPTION OF CHANGES: The existing packaging in combination with the logic added in the code for HASH HERE causes segmentation faults for most model simulations that use km_opt=2. The packaging is important, but we have a broken repository. The packaging will be removed, developers will fix the problem, and put the packaging back in the Registry file. LIST OF MODIFIED FILES: modified: Registry/Registry.EM_COMMON TESTS CONDUCTED: - [x] With original packaging, all tests with km_opt=2 failed - [x] With mods (removing km_opt=5 packaging), km_opt=2 and km_opt=5 tests pass
Collaborator
|
@davegill This looks ok to me. |
Contributor
Author
|
@kkeene44 @weiwangncar @dudhia |
kkeene44
approved these changes
Nov 15, 2019
liujake
added a commit
that referenced
this pull request
Feb 12, 2020
TYPE: bug fix KEYWORDS: wrfplus, TL/AD code SOURCE: internal DESCRIPTION OF CHANGES: Two recent WRF model code changes break the wrfplus compilation: 1. ESMF name change This modification allowed the CTSM development to use standard ESMF without conflicting with WRF _old_ ESMF library namespace. Commit 8af5385, PR #1066 "Enabling WRF build with ESMF library" 2. module_diffusion_em_ad.F, 3d scale aware TKE (one of these, take your pick) Commit d059afe, PR #972 "Add a scale-adaptive 3DTKE parameterization scheme as a subgrid mixing option Commit 6d95883, PR #1012 "SMS3dTKE: Remove broken packaging for km_opt=5" Commit 94e5ed9, PR #1013 "Add missing "IF km_opt==5" tests for diag computations" Commit dd0c209, PR #1026 "Fixing the problem that km_opt=5 breaks km_opt=2 and cleaning codes" LIST OF MODIFIED FILES: M share/mediation_integrate.F M wrftladj/module_diffusion_em_ad.F TESTS CONDUCTED: wrfplus code compiles now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: packaging, sms3dtke
SOURCE: Internal
DESCRIPTION OF CHANGES:
The existing packaging in combination with the logic added in the
code for PR #972 (Add a scale-adaptive 3DTKE parameterization scheme as a subgrid
mixing option) d059afe causes segmentation faults for most model
simulations that use km_opt=2.
The packaging is important, but we have a broken repository. The
packaging will be removed, developers will fix the problem, and
then put the packaging back into the Registry file for this option.
Jan Mandel states:
Perhaps these are the variables to start the seg fault investigation to re-introduce
packaging for this option.
LIST OF MODIFIED FILES:
modified: Registry/Registry.EM_COMMON
TESTS CONDUCTED: