Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated figures, descriptions for Driver Station pages #2309

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

Updated figures, descriptions for Driver Station pages #2309

wants to merge 40 commits into from

Conversation

pjbuterbaugh
Copy link
Contributor

Closes #2267.

@pjbuterbaugh
Copy link
Contributor Author

Finishing up figures for logging section.

@sciencewhiz
Copy link
Collaborator

In general, it would be better to replace the old pictures with the new pictures, rather then deleting the old file and adding a new file. This keeps from breaking links in other files (see failing checks), and also makes it easier to review.

AyushSagar16 and others added 25 commits September 17, 2023 07:53
@AyushSagar16 @pjbuterbaugh
Added videos (wpilibsuite#2264)
44db3c2
@calcmogul @pjbuterbaugh
Document all of universal heartbeat CAN packet (wpilibsuite#2269)
96891de
@calcmogul @pjbuterbaugh
Fix universal heartbeat API ID (wpilibsuite#2270)
9e05d74 
Fixes wpilibsuite#2241.
@sciencewhiz @pjbuterbaugh
Add CIMCoder to encoder examples. (wpilibsuite#2271)
d752886 
https://www.chiefdelphi.com/t/i-need-cim-encoder-java-codes/438041
@rzblue @pjbuterbaugh
Update code formatting article after wpiformat update (wpilibsuite#2268)
d2c15fd 
* Update code formatting article after wpiformat update

* update RLI
@sciencewhiz @pjbuterbaugh
Update MiKTex packages and instructions to work with latest versions (w…
d324731 
…pilibsuite#2275)
@sciencewhiz @pjbuterbaugh
Reorder build dependencies so required ones are first (wpilibsuite#2280)
27cc09a 
Add same note for rsvg-convert as was there for MiKTeX
@sciencewhiz @pjbuterbaugh
Update PWM scaling for wpilibsuite/allwpilib#5283 (wpilibsuite#2277)
af6c0af
@sciencewhiz @pjbuterbaugh
Update requests to 2.31.0 to fix dependabot (wpilibsuite#2285)
cb505fa
@rzblue @pjbuterbaugh
Add andymark RSL option (wpilibsuite#2286)
38831de
@sciencewhiz @pjbuterbaugh
Add instructions for disablinb VS Code line length linting (wpilibsui…
a277be7 
…te#2279)
@Gold856 @pjbuterbaugh
Document IZone (wpilibsuite#2266)
5718da0
@Gold856 @pjbuterbaugh
Fix code tab (wpilibsuite#2290)
9ee958a
@AngleSideAngle @pjbuterbaugh
fixed link in tutorial-intro.rst (wpilibsuite#2292)
3435558 
* fixed link in tutorial-intro.rst

* Fix :ref: in tutorial-intro.rst
@AyushSagar16 @pjbuterbaugh
Fixed warning tag (wpilibsuite#2298)
9b712ae
@sciencewhiz @pjbuterbaugh
Update macOS and Xcode version (wpilibsuite#2295)
74fdfdb 
Needed for wpilibsuite/allwpilib#5379
@calcmogul @pjbuterbaugh
Update accelerometer docs (wpilibsuite#2291)
2b73d22 
The Accelerometer interface was deprecated in wpilibsuite/allwpilib#5445.
@calcmogul @pjbuterbaugh
Update gyro docs (wpilibsuite#2294)
d648528 
* Update gyro docs

The Gyro interface was deprecated in wpilibsuite/allwpilib#5445.

* Fix title levels
@rzblue @pjbuterbaugh
Remove references to the "old" PIDController (wpilibsuite#2288)
22e337f
@rzblue @pjbuterbaugh
Remove new command based "What's changed" (wpilibsuite#2287)
bdcd855 
* Remove old command based stuff

also fix some broken links I found

* add redirect
@cfinn68916 @pjbuterbaugh
Add c++ counterparts for java shuffleboard snippets (wpilibsuite#2299)
991f058 
* Add c++ counterparts for java shuffleboard snippets

* Add frc:: to c++ examples
@sciencewhiz @pjbuterbaugh
Update certify to fix dependabot (wpilibsuite#2307)
27bafb3
@guineawheek @pjbuterbaugh
add the redux vendordep (wpilibsuite#2256) (wpilibsuite#2256)
643bc5d
@Gold856 @calcmogul @pjbuterbaugh
Update TrapezoidProfile docs (wpilibsuite#2301)
f30633a 
* Update TrapezoidProfile docs

* Update source/docs/software/advanced-controls/controllers/trapezoidal-profiles.rst

Co-authored-by: Tyler Veness <[email protected]>

---------

Co-authored-by: Tyler Veness <[email protected]>
@pjbuterbaugh
Correcting branch to contain correct changes.
61a418c
@pjbuterbaugh
Copy link
Contributor Author

In general, it would be better to replace the old pictures with the new pictures, rather then deleting the old file and adding a new file. This keeps from breaking links in other files (see failing checks), and also makes it easier to review.

Didn't see this - will fix.

sciencewhiz
sciencewhiz reviewed Oct 30, 2023
View reviewed changes
...re/driverstation/images/driver-station-log-viewer/open_ds_log_viewer_from_driver_station.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some changes in the 2024 beta DS. This picture and maybe some others will need to be updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will evaluate and determine what needs to be changed, thanks for the head's up.

sciencewhiz
sciencewhiz reviewed Jan 16, 2024
View reviewed changes
source/docs/software/driverstation/images/driver-station/ds-diagnostics-tab.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get a screenshot that has less CAN devices attached so that it still shows free memory and disk space?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sciencewhiz sciencewhiz sciencewhiz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parts of the Driver Station pages are out of date
9 participants
@pjbuterbaugh @sciencewhiz @AyushSagar16 @calcmogul @rzblue @Gold856 @AngleSideAngle @cfinn68916 @guineawheek