Fix compilation of MathExtras.h on Windows with /sdl #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix copied from the LLVM main branch
ThadHouse
previously approved these changes
Oct 24, 2023
|
This should be done as a patch in upstream_utils, not by modifying the llvm source. https://github.com/wpilibsuite/allwpilib/tree/main/upstream_utils#adding-patch-to-thirdparty-library |
I reverted the previous file changes locally and ran the python script with the latest patch and confirmed that there were no changes compared to the MathExtras.h header compared to the previous commit.
calcmogul
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, compilation fails with error C4146 on the MathExtras.h header when using the /sdl compiler flag. Since unary minus performs two's complement, it is equivalent to performing ones' complement (bitwise NOT) on the unsigned number and adding one.
This fix was copied from the LLVM main branch: llvm/llvm-project#68978