[hal] Simulation: Fix REV PH solenoids 8+ #5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation ignores channels eight and above in the simulator.
rzblue
approved these changes
Feb 23, 2023
|
@superpenguin612 were you able to confirm that this fixed the issue you were seeing? |
|
I was unable to confirm, can someone compile and test this? |
PeterJohnson
changed the title
|
This still shows grayed out in the simulator for REV. |
|
See #4302. |
Starlight220
pushed a commit
to Starlight220/allwpilib
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation ignores channels eight and above in the simulator.