Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard stale pose estimates #5045

Merged
merged 23 commits into from
Feb 4, 2023
Merged

Discard stale pose estimates #5045

merged 23 commits into from
Feb 4, 2023

Conversation

jlmcmchl
Copy link
Contributor

@jlmcmchl jlmcmchl commented Feb 4, 2023

Fixes #4952

@jlmcmchl
Copy link
Contributor Author

jlmcmchl commented Feb 4, 2023

/wpiformat

calcmogul
calcmogul requested changes Feb 4, 2023
View reviewed changes
wpimath/src/main/native/include/frc/estimator/MecanumDrivePoseEstimator.h Outdated Show resolved Hide resolved
wpimath/src/main/native/include/frc/estimator/DifferentialDrivePoseEstimator.h Outdated Show resolved Hide resolved
wpimath/src/main/native/include/frc/estimator/MecanumDrivePoseEstimator.h Outdated Show resolved Hide resolved
wpimath/src/main/native/include/frc/estimator/SwerveDrivePoseEstimator.h Outdated Show resolved Hide resolved
wpimath/src/main/native/include/frc/estimator/SwerveDrivePoseEstimator.h Outdated Show resolved Hide resolved
wpimath/src/test/java/edu/wpi/first/math/estimator/SwerveDrivePoseEstimatorTest.java Outdated Show resolved Hide resolved
wpimath/src/main/native/cpp/estimator/DifferentialDrivePoseEstimator.cpp Outdated Show resolved Hide resolved
wpimath/src/main/native/cpp/estimator/MecanumDrivePoseEstimator.cpp Outdated Show resolved Hide resolved
wpimath/src/main/native/include/frc/estimator/DifferentialDrivePoseEstimator.h Outdated Show resolved Hide resolved
wpimath/src/main/native/include/frc/estimator/SwerveDrivePoseEstimator.h Outdated Show resolved Hide resolved
calcmogul
calcmogul requested changes Feb 4, 2023
View reviewed changes
wpimath/src/main/java/edu/wpi/first/math/estimator/DifferentialDrivePoseEstimator.java Outdated Show resolved Hide resolved
wpimath/src/main/java/edu/wpi/first/math/estimator/DifferentialDrivePoseEstimator.java Outdated Show resolved Hide resolved
wpimath/src/main/java/edu/wpi/first/math/estimator/DifferentialDrivePoseEstimator.java Outdated Show resolved Hide resolved
wpimath/src/main/java/edu/wpi/first/math/estimator/MecanumDrivePoseEstimator.java Outdated Show resolved Hide resolved
wpimath/src/main/java/edu/wpi/first/math/estimator/MecanumDrivePoseEstimator.java Outdated Show resolved Hide resolved
wpimath/src/main/java/edu/wpi/first/math/estimator/SwerveDrivePoseEstimator.java Outdated Show resolved Hide resolved
wpimath/src/main/java/edu/wpi/first/math/estimator/SwerveDrivePoseEstimator.java Outdated Show resolved Hide resolved
wpimath/src/main/java/edu/wpi/first/math/estimator/SwerveDrivePoseEstimator.java Outdated Show resolved Hide resolved
@calcmogul
Update wpimath/src/main/native/include/frc/estimator/MecanumDrivePose…
4d8c897 
…Estimator.h
@calcmogul
Update wpimath/src/main/native/include/frc/estimator/DifferentialDriv…
fc5802e 
…ePoseEstimator.h
@calcmogul
Update wpimath/src/main/native/include/frc/estimator/MecanumDrivePose…
1cdf510 
…Estimator.h
@calcmogul
Update wpimath/src/main/native/include/frc/estimator/SwerveDrivePoseE…
6c964a7 
…stimator.h
@calcmogul
Update wpimath/src/main/native/include/frc/estimator/SwerveDrivePoseE…
734af06 
…stimator.h
@calcmogul
Update wpimath/src/test/java/edu/wpi/first/math/estimator/SwerveDrive…
4607d92 
…PoseEstimatorTest.java
@calcmogul
Update wpimath/src/main/native/cpp/estimator/DifferentialDrivePoseEst…
cab2b94 
…imator.cpp
@calcmogul
Update wpimath/src/main/native/cpp/estimator/MecanumDrivePoseEstimato…
3d19f18 
…r.cpp
@calcmogul
Update wpimath/src/main/native/include/frc/estimator/DifferentialDriv…
c595302 
…ePoseEstimator.h
@calcmogul
Update wpimath/src/main/native/include/frc/estimator/SwerveDrivePoseE…
744f794 
…stimator.h
@calcmogul
Update wpimath/src/main/java/edu/wpi/first/math/estimator/Differentia…
72fc2a0 
…lDrivePoseEstimator.java
@calcmogul
Update wpimath/src/main/java/edu/wpi/first/math/estimator/Differentia…
60b11f5 
…lDrivePoseEstimator.java
@calcmogul
Update wpimath/src/main/java/edu/wpi/first/math/estimator/Differentia…
f7692db 
…lDrivePoseEstimator.java
@calcmogul
Update wpimath/src/main/java/edu/wpi/first/math/estimator/MecanumDriv…
b3f1a21 
…ePoseEstimator.java
@calcmogul
Update wpimath/src/main/java/edu/wpi/first/math/estimator/MecanumDriv…
c9b3e54 
…ePoseEstimator.java
@calcmogul
Update wpimath/src/main/java/edu/wpi/first/math/estimator/SwerveDrive…
f345310 
…PoseEstimator.java
@calcmogul
Update wpimath/src/main/java/edu/wpi/first/math/estimator/SwerveDrive…
782ff01 
…PoseEstimator.java
@calcmogul
Update wpimath/src/main/java/edu/wpi/first/math/estimator/SwerveDrive…
2d51895 
…PoseEstimator.java
@calcmogul
Copy link
Member

/wpiformat

@calcmogul calcmogul marked this pull request as ready for review February 4, 2023 01:04
@calcmogul calcmogul requested a review from a team as a code owner February 4, 2023 01:04
@PeterJohnson PeterJohnson merged commit 4079eab into wpilibsuite:main Feb 4, 2023
@joecaraccio joecaraccio mentioned this pull request Feb 12, 2023
Closed
@KangarooKoala KangarooKoala mentioned this pull request Feb 16, 2023
Closed
Starlight220 pushed a commit to Starlight220/allwpilib that referenced this pull request Mar 2, 2023
@jlmcmchl @calcmogul @Starlight220
[wpimath] Discard stale pose estimates (wpilibsuite#5045)
c9f9a15 
Co-authored-by: Tyler Veness <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SwerveDrivePoseEstimator#addVisionMeasurement throws a ConcurrentModificationException
3 participants
@jlmcmchl @calcmogul @PeterJohnson