Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Add example programs for AprilTags detection #4932

Merged
merged 19 commits into from
Jan 14, 2023

Conversation

fovea1959
Copy link
Contributor

Added C++ and Java examples for AprilTags detection. Tested in simulator, but not on roboRIO (yet).

@fovea1959 fovea1959 requested review from a team as code owners January 12, 2023 15:41
@fovea1959 fovea1959 marked this pull request as draft January 12, 2023 18:10
@Starlight220
Copy link
Member

Starlight220 commented Jan 12, 2023

  • Remove the "complete list" tag from the example JSONs. It's meaningless. Perhaps add a "April Tags" example instead.

  • Perhaps rename the example "AprilTagVision" for consistency with the "SimpleVision" and "IntermediateVision" examples.

  • The description feels rather wordy; I feel like it can be shortened. I think the key phrase is "on-RIO AprilTag detection", which is missing.

  • We might also want to mention in the example's documentation that it isn't very efficient.

@fovea1959
Copy link
Contributor Author

  • Remove the "complete list" tag from the example JSONs. It's meaningless. Perhaps add a "April Tags" example instead.

both done.

  • Perhaps rename the example "AprilTagVision" for consistency with the "SimpleVision" and "IntermediateVision" examples.

It's not just vision, there is more.

  • The description feels rather wordy; I feel like it can be shortened. I think the key phrase is "on-RIO AprilTag detection", which is missing.

Done.

  • We might also want to mention in the example's documentation that it isn't very efficient.

Is there a more efficient alternative to point someone too?

@fovea1959 fovea1959 marked this pull request as ready for review January 12, 2023 19:25
checks on github threw:
error: error reading /__w/allwpilib/allwpilib/build/wpimath/thirdparty/ejml/ejml-core-0.41.jar; zip file is empty
error: error reading /__w/allwpilib/allwpilib/build/wpimath/thirdparty/ejml/ejml-zdense-0.41.jar; zip file is empty
not my fault.
@Starlight220
Copy link
Member

It's not just vision, there is more.

What more?

Is there a more efficient alternative to point someone too?

Using a coprocessor, same as always. The RIO is notoriously bad at vision processing.

@fovea1959
Copy link
Contributor Author

It's not just vision, there is more.

What more?

...some analysis of the acquired images. All the other *Vision just acquire the image, perhaps statically mark it up, and send it to the dashboard.

Is there a more efficient alternative to point someone too?

Using a coprocessor, same as always. The RIO is notoriously bad at vision processing.

I would argue the RIO is slow, not inefficient; less hardware/complexity = less performance, but the ratio of complexity to performance is not bad.

...but in the interests of getting this example in the hands of teams that are already asking for it and do not have the resources to do a coprocessor (where the heck can you get a rPi right now?), I'll add something. Where do you want that warning, in the source, or in the description that we are trying to keep not-wordy? Do we also need to add it to the other vision examples?

@fovea1959
Copy link
Contributor Author

fovea1959 commented Jan 12, 2023 via email

@fovea1959 fovea1959 marked this pull request as draft January 13, 2023 15:41
@fovea1959
Copy link
Contributor Author

  • Perhaps rename the example "AprilTagVision" for consistency with the "SimpleVision" and "IntermediateVision" examples.

done.

@fovea1959 fovea1959 marked this pull request as ready for review January 14, 2023 02:03
@fovea1959 fovea1959 requested review from calcmogul, PeterJohnson and rzblue and removed request for calcmogul and PeterJohnson January 14, 2023 02:04
@fovea1959 fovea1959 requested review from calcmogul and removed request for rzblue January 14, 2023 02:28
@PeterJohnson PeterJohnson changed the title [examples] Add example programs for AprilTags detection [#4929]. [examples] Add example programs for AprilTags detection Jan 14, 2023
@PeterJohnson PeterJohnson merged commit cf1a411 into wpilibsuite:main Jan 14, 2023
@Starlight220 Starlight220 linked an issue Jan 15, 2023 that may be closed by this pull request
Starlight220 pushed a commit to Starlight220/allwpilib that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an AprilTags detection example
6 participants